systemvm: fix pep8 errors - #2068
Closed
resmo wants to merge 1 commit into
Closed
Conversation
Contributor
|
thanks @resmo , good to see someone cares. provided the import changes are correct I see no issues so based on the code |
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-680 |
DaanHoogland
approved these changes
May 2, 2017
DaanHoogland
left a comment
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
LGTM, tests needed for the import parts
Member
Author
|
there are a few important open PR conflicting with this cleanup. rebasing asap these are merged. |
Contributor
|
Merge conflicts :( Otherwise a LGTM from me, but can you fix these? |
Member
|
@resmo LGTM, is this ready for testing/merging, can you fix conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed pep8 errors. in
baremetal-vr.pyalso replaced "windows carriage return" to "unix carriage return".Before: