CLOUDSTACK-8829 : Consecutive cold migration fails. - #2056
Merged
Conversation
Contributor
Author
|
Hi @borisstoyanov Bhai, |
Contributor
|
@priyankparihar I can trigger smoketests for that. |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-684 |
Contributor
|
@blueorangutan test centos7 vmware5.5u3 |
|
@borisstoyanov unsupported parameters provided. Supported mgmt server os are: |
Contributor
|
@blueorangutan test centos7 vmware-55u3 |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests |
|
Trillian test result (tid-1044)
|
borisstoyanov
left a comment
borisstoyanov
left a comment
Contributor
There was a problem hiding this comment.
the virtio test failures will be fixed in a separate FR
sateesh-chodapuneedi
approved these changes
May 2, 2017
sateesh-chodapuneedi
left a comment
sateesh-chodapuneedi
left a comment
Member
There was a problem hiding this comment.
LGTM for code changes.
DaanHoogland
approved these changes
May 2, 2017
| } catch (final Exception e) { | ||
| throw new CloudRuntimeException("Failed to unregister VM: " + vm.getInstanceName() + " from source host: " + srcHost.getId() + | ||
| _agentMgr.send(srcHostId, uvc); | ||
| } catch (final AgentUnavailableException | OperationTimedoutException e) { |
priyankparihar
force-pushed
the
CLOUDSTACK-8829
branch
from
May 4, 2017 09:36
ebe414e to
88b0459
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue - Consecutive VM cold migration fails.
Root Cause Analysis - In case of VMware, if VM is being cold migrated between clusters belonging to two different VMware DCs, Cloudstack unregisters the VM from the source host and cleans up the associated VM files. The check if a VM is being cold migrated across DCs is made using the source host id. In case of consecutive cold migrations since the source host id of a VM is NULL and no VM exists, Cloudstack should skip the check
Proposed Solution - Attempt to unregister a VM in another DC, only if there is a host associated with a VM.
This closes #797