rbd: Use libvirt to create new volumes and not rados-java - #2039
Merged
Conversation
Since libvirt 1.2.2 libvirt will properly create volumes using RBD format 2. We can use libvirt to creates the volumes which strips a bit of code from the CloudStack Agent's responsbility. RBD format 2 is already used by all volumes created by CloudStack. This format is the most recent format of RBD and is still actively being developed. This removes the support for Ubuntu 12.04 as that does not have the proper libvirt version available. Signed-off-by: Wido den Hollander <wido@widodh.nl>
wido
force-pushed
the
rbd-create-libvirt
branch
from
April 14, 2017 19:37
808e88c to
d88b30f
Compare
ACS CI BVT RunSumarry: Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0 Failed tests: Skipped tests: Passed test suits: |
yadvr
reviewed
Jul 13, 2017
| Architecture: all | ||
| Depends: ${python:Depends}, openjdk-8-jre-headless | java8-runtime-headless | java8-runtime, cloudstack-common (= ${source:Version}), lsb-base (>= 4.0), libcommons-daemon-java, openssh-client, qemu-kvm (>= 1.0), libvirt-bin (>= 0.9.8), uuid-runtime, iproute, ebtables, vlan, jsvc, ipset, python-libvirt, ethtool, iptables, lsb-release, init-system-helpers (>= 1.14~) | ||
| Depends: ${python:Depends}, openjdk-8-jre-headless | java8-runtime-headless | java8-runtime, cloudstack-common (= ${source:Version}), lsb-base (>= 4.0), libcommons-daemon-java, openssh-client, qemu-kvm (>= 1.0), libvirt-bin (>= 1.2.2), uuid-runtime, iproute, ebtables, vlan, jsvc, ipset, python-libvirt, ethtool, iptables, lsb-release, init-system-helpers (>= 1.14~) | ||
| Recommends: init-system-helpers |
Member
There was a problem hiding this comment.
This might break pkg building or installation on 14.04/16.04. @ustcweizhou do you remember doing similar changes?
Contributor
Author
There was a problem hiding this comment.
I checked the libvirt version, that one is present in Ubuntu 14.04
Member
|
@wido thanks, will kick some tests. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-798 |
Member
|
@blueorangutan help |
|
@rhtyd I understand these words: "help", "hello", "thanks", "package", "test" Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'abhinandanprateek', 'PaulAngus', 'borisstoyanov', 'DaanHoogland'] |
Member
|
@blueorangutan test ubuntu kvm-ubuntu |
|
@rhtyd a Trillian-Jenkins test job (ubuntu mgmt + kvm-ubuntu) has been kicked to run smoke tests |
|
Trillian test result (tid-1201)
|
Contributor
|
@wido We're taking a look at this one as well. @nathanejohnson @dmabry |
Member
|
@wido seems some errors, I'll rerun against centos |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1247)
|
Member
|
LGTM, I'm not aware of Ceph/RBD + ACS users using CentOS6/7 based hosts so this can be accepted. However, for this change an additional review is asked. |
Contributor
Author
|
CentOS 7 has libvirt 2.0.0 and therefor is no problem. CentOS 6 has an ancient version, but Ceph doesn't support CentOS 6 anymore. |
Member
|
Alright, with that LGTM. @kiwiflyer do you have any comment/feedback to share? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since libvirt 1.2.2 libvirt will properly create volumes
using RBD format 2.
We can use libvirt to creates the volumes which strips a bit of
code from the CloudStack Agent's responsbility.
RBD format 2 is already used by all volumes created by CloudStack.
This format is the most recent format of RBD and is still actively
being developed.
This removes the support for Ubuntu 12.04 as that does not have the
proper libvirt version available.
Signed-off-by: Wido den Hollander wido@widodh.nl