Skip to content

CLOUDSTACK-9589 vmName entries from host_details table for the VM's w… - #1759

Merged
karuturi merged 1 commit into
apache:masterfrom
yvsubhash:CLOUDSTACK-9589
Jun 7, 2017
Merged

CLOUDSTACK-9589 vmName entries from host_details table for the VM's w…#1759
karuturi merged 1 commit into
apache:masterfrom
yvsubhash:CLOUDSTACK-9589

Conversation

@yvsubhash

@yvsubhash yvsubhash commented Nov 10, 2016

Copy link
Copy Markdown

CLOUDSTACK-9589 vmName entries from host_details table for the VM's whose state is Expunging should be deleted during upgrade from older versions

Having vmName entries for VMs in 'expunging' states would cause with deploying VMs with matching host tags fail. So removing them during upgrade

jburwell
jburwell suggested changes Nov 14, 2016
View reviewed changes
Comment thread setup/db/db/schema-480to481-cleanup.sql Outdated
-- Schema cleanup from 4.8.0 to 4.8.1;
--;

DELETE FROM `cloud`.`host_details` where name = 'vmName' and value in (select name from `cloud`.`vm_instance` where state = 'Expunging' and hypervisor_type ='BareMetal');

@jburwell jburwell Nov 14, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change scoped only to the baremetal hypervisor? It would seem that it should apply to all hypervisors.

@jburwell

jburwell commented Nov 14, 2016

Copy link
Copy Markdown
Contributor

This change has been added to the schema-480to481.sql script. Since 4.8.1 has already shipped, this script will not be applied for those users. Therefore, this change needs to be placed in the schema-481to4820.sql script.

Also, the base branch for this PR is master. However, the database change is targeted at 4.8. Therefore, the base branch should be changed to 4.8.

@yvsubhash
yvsubhash changed the base branch from master to 4.8 November 17, 2016 11:23
@yvsubhash

yvsubhash commented Nov 17, 2016 •
edited
Loading

Copy link
Copy Markdown
Author

@jburwell
Change is moved to schema-481to4820.sql and base branch is changed to 4.8 and the property AFAIK 'vmName' in host_details table gets used only in case of 'BareMetal'

@yadvr

yadvr commented Nov 20, 2016

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Nov 20, 2016

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Nov 20, 2016

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-174

@yadvr

yadvr commented Nov 25, 2016

Copy link
Copy Markdown
Member

Move this to 4.9 or master branch.

@yvsubhash
yvsubhash changed the base branch from 4.8 to 4.9 December 4, 2016 17:27
@yvsubhash

yvsubhash commented Dec 4, 2016

Copy link
Copy Markdown
Author

@rhtyd rebased to 4.9 branch as suggested

@yadvr

yadvr commented Dec 9, 2016

Copy link
Copy Markdown
Member

@yvsubhash can you move the changes to 490to4910.sql ? Also rebase against latest 4.9, squash your changes.

@yvsubhash

yvsubhash commented Jan 18, 2017

Copy link
Copy Markdown
Author

@rhtyd can you suggest me the branch for rebasing this commit against?

@yvsubhash
yvsubhash changed the base branch from 4.9 to master March 2, 2017 09:53
@harikrishna-patnala

harikrishna-patnala commented Mar 2, 2017

Copy link
Copy Markdown
Member

LGTM

@yvsubhash
yvsubhash force-pushed the CLOUDSTACK-9589 branch 2 times, most recently from af24f59 to 3a2ae6e Compare March 6, 2017 06:31
@cloudmonger

cloudmonger commented Mar 13, 2017

Copy link
Copy Markdown

ACS CI BVT Run

Sumarry:
Build Number 463
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=1
Skipped=7

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

  • test_routers_network_ops.py

  • test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 2 runs

Skipped tests:
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

@yvsubhash

yvsubhash commented Apr 13, 2017

Copy link
Copy Markdown
Author

tag:mergeready

subhash yedugundla
CLOUDSTACK-9589 vmName entries from host_details table for the VM's w…
49a661b 
…hose state is Expunging should be deleted during upgrade from older versions
@karuturi karuturi added this to the 4.10.0.0 milestone Jun 6, 2017
@karuturi
karuturi merged commit be6e1a8 into apache:master Jun 7, 2017
lucas-a-martins pushed a commit to scclouds/cloudstack that referenced this pull request Jan 29, 2024
Daniel Augusto Veronezi Salvador
Merge branch 'fix-use-of-vmfs-local-storage' into '4.18.0.0-scclouds'
2ca05d4 
Corrige o uso de _storages_ locais do tipo `VMFS`

Closes apache#1759

See merge request scclouds/scclouds!717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jburwell jburwell jburwell requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.10.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@yvsubhash @jburwell @yadvr @blueorangutan @harikrishna-patnala @cloudmonger @karuturi