Update tools/build/build_asf.sh - #13812
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the ASF release build helper script to ensure additional release artifacts don’t retain -SNAPSHOT suffixes, aligning Docker images and legacy hypervisor plugin modules with the intended release versioning.
Changes:
- Strip
-SNAPSHOTfromtools/docker/Dockerfile.s390xduring the release build step. - Strip
-SNAPSHOTfromplugins/hypervisors/ovm/pom.xmlandplugins/hypervisors/ovm3/pom.xmlduring the release build step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| perl -pi -e "s/-SNAPSHOT//" tools/docker/Dockerfile.marvin | ||
| perl -pi -e "s/-SNAPSHOT//" tools/docker/Dockerfile.centos6 | ||
| perl -pi -e "s/-SNAPSHOT//" tools/docker/Dockerfile.s390x | ||
| perl -pi -e "s/-SNAPSHOT//" plugins/hypervisors/ovm/pom.xml | ||
| perl -pi -e "s/-SNAPSHOT//" plugins/hypervisors/ovm3/pom.xml |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13812 +/- ##
============================================
- Coverage 19.65% 19.64% -0.01%
+ Complexity 19792 19790 -2
============================================
Files 6368 6368
Lines 574881 574889 +8
Branches 70351 70353 +2
============================================
- Hits 112970 112964 -6
- Misses 449639 449655 +16
+ Partials 12272 12270 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
no test required, merging |
|
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 24.50% |
| Branch coverage | 18.67% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run



Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?