Skip to content

Update tools/build/build_asf.sh - #13812

Merged
weizhouapache merged 1 commit into
mainfrom
4.23-fix-build-asf
Aug 6, 2026
Merged

Update tools/build/build_asf.sh#13812
weizhouapache merged 1 commit into
mainfrom
4.23-fix-build-asf

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copilot AI lite review requested due to automatic review settings August 6, 2026 10:05
@weizhouapache weizhouapache added this to the 4.23.0 milestone Aug 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ASF release build helper script to ensure additional release artifacts don’t retain -SNAPSHOT suffixes, aligning Docker images and legacy hypervisor plugin modules with the intended release versioning.

Changes:

  • Strip -SNAPSHOT from tools/docker/Dockerfile.s390x during the release build step.
  • Strip -SNAPSHOT from plugins/hypervisors/ovm/pom.xml and plugins/hypervisors/ovm3/pom.xml during the release build step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/build/build_asf.sh
Comment on lines 104 to +108
perl -pi -e "s/-SNAPSHOT//" tools/docker/Dockerfile.marvin
perl -pi -e "s/-SNAPSHOT//" tools/docker/Dockerfile.centos6
perl -pi -e "s/-SNAPSHOT//" tools/docker/Dockerfile.s390x
perl -pi -e "s/-SNAPSHOT//" plugins/hypervisors/ovm/pom.xml
perl -pi -e "s/-SNAPSHOT//" plugins/hypervisors/ovm3/pom.xml
@weizhouapache

Copy link
Copy Markdown
Member Author

tools/docker/Dockerfile.s390x was added in #12337
ovm/ovm3 have been deprecated: #11196 ,they will be removed in next release

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.64%. Comparing base (4f11707) to head (48e7100).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13812      +/-   ##
============================================
- Coverage     19.65%   19.64%   -0.01%     
+ Complexity    19792    19790       -2     
============================================
  Files          6368     6368              
  Lines        574881   574889       +8     
  Branches      70351    70353       +2     
============================================
- Hits         112970   112964       -6     
- Misses       449639   449655      +16     
+ Partials      12272    12270       -2     
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 20.92% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache

Copy link
Copy Markdown
Member Author

no test required, merging

@weizhouapache
weizhouapache merged commit 5a67f19 into main Aug 6, 2026
27 of 28 checks passed
@weizhouapache
weizhouapache deleted the 4.23-fix-build-asf branch August 6, 2026 10:29
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 24.50%
Branch coverage 18.67%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants