Skip to content

UI: expose network ACL replacement from VPC tiers - #13794

Draft
Dogface2k wants to merge 1 commit into
apache:mainfrom
Dogface2k:draft/ui-vpc-tier-acl
Draft

UI: expose network ACL replacement from VPC tiers#13794
Dogface2k wants to merge 1 commit into
apache:mainfrom
Dogface2k:draft/ui-vpc-tier-acl

Conversation

@Dogface2k

@Dogface2k Dogface2k commented Aug 4, 2026

Copy link
Copy Markdown

Summary

Expose the existing replaceNetworkACLList operation from the VPC tiers view.

Operators can select a tier's replacement ACL, submit the existing typed API action, and receive the normal asynchronous-job result and inventory refresh. The modal is destroyed on close so it does not share a mounted form instance with the create-tier modal.

Scope

  • VPC tier UI only
  • Existing replaceNetworkACLList API; no server/API changes
  • ACL choices are loaded for the current VPC
  • Permission-unavailable action is disabled
  • Existing ACL warning messages are reused

Verification

  • git diff --check
  • Browser interaction and production UI build remain to be exercised before merge: open VPC tiers, replace an ACL, verify async completion and refresh, verify permission-negative behavior, and reopen the create-tier form.

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.64%. Comparing base (4f11707) to head (1da4322).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13794      +/-   ##
============================================
- Coverage     19.65%   19.64%   -0.01%     
+ Complexity    19792    19788       -4     
============================================
  Files          6368     6368              
  Lines        574881   574901      +20     
  Branches      70351    70352       +1     
============================================
- Hits         112970   112946      -24     
- Misses       449639   449688      +49     
+ Partials      12272    12267       -5     
Flag Coverage Δ
uitests 3.41% <ø> (-0.01%) ⬇️
unittests 20.92% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache

Copy link
Copy Markdown
Member

@Dogface2k
can you share a screenshot ?

there is already an icon to replace ACL list
image

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13794 (QA-JID-970)

@DaanHoogland

DaanHoogland commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
Screenshot 2026-08-05 at 11 42 42

@weizhouapache there is now also a button in the vpc tiers overview list. I think that is fine as well.

(edit: your sshot is from the tiers details page, this is extra)

@Dogface2k

Dogface2k commented Aug 5, 2026

Copy link
Copy Markdown
Author

I got something to check as well think it's on another PR not this but will go over all drafts soon just currently sorting my branches out as I have like 6 PRs still missing relating to other PRs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants