Packaging: accept normalized Marvin archive names - #13793
Draft
Dogface2k wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13793 +/- ##
=========================================
Coverage 19.65% 19.65%
+ Complexity 19792 19790 -2
=========================================
Files 6368 6368
Lines 574881 574881
Branches 70351 70351
=========================================
+ Hits 112970 112974 +4
+ Misses 449639 449635 -4
Partials 12272 12272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
weizhouapache
approved these changes
Aug 5, 2026
weizhouapache
left a comment
weizhouapache
left a comment
Member
There was a problem hiding this comment.
code lgtm
it is consistent with @DaanHoogland 's PR: #11873
Member
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setuptools 69.3.0 introduced PEP 625-compliant normalization of
source-distribution filenames.
Although the Python project is declared as
name="Marvin", currentSetuptools versions produce:
Older versions may still produce:
Update the Debian packaging consumers to match
[Mm]arvin-*.tar.gz,allowing both forms to remain supported.
This only changes archive discovery during packaging and installation.
It does not alter the Marvin archive contents or CloudStack runtime
behaviour.
still need review
packaging/el8/cloud.spec
packaging/suse15/cloud.spec
tools/marvin/pom.xml
will tighten patterns