Skip to content

Identify Guest Agent connection error by the ordinal instead of message (KBOSS) #13789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GaOrtiga wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Identify Guest Agent connection error by the ordinal instead of message (KBOSS) #13789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rvisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ public class LibvirtComputingResource extends ServerResourceBase implements Serv

public static final String CGROUP_V2 = "cgroup2fs";

public static final String AGENT_IS_NOT_CONNECTED = "QEMU guest agent is not connected";
public static final Integer AGENT_UNRESPONSIVE_ERROR_ORDINAL = 86;
Comment thread
GaOrtiga marked this conversation as resolved.

/**
* Virsh command to merge (blockcommit) snapshot into the base file.<br><br>
Expand Down Expand Up @@ -7185,7 +7185,7 @@ public Map<String, Long> createDiskOnlyVmSnapshotForRunningVm(List<Pair<VolumeOb
} catch (LibvirtException e) {
String errorMsg = String.format("Creation of disk-only VM snapshot for VM [%s] failed due to %s.", vmName, e.getMessage());
boolean isVmConsistent = false;
if (e.getMessage().contains(AGENT_IS_NOT_CONNECTED)) {
if (AGENT_UNRESPONSIVE_ERROR_ORDINAL.equals(e.getError().getCode().ordinal())) {

@JoaoJandre JoaoJandre Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also valid

errorMsg = "QEMU guest agent is not connected. If the VM has been recently started, it might connect soon. Otherwise the VM does not have the" +
" guest agent installed; thus the QuiesceVM parameter is not supported.";
isVmConsistent = true;
Expand Down
2 changes: 1 addition & 1 deletion .../java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtValidateKbossVmCommandWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ private boolean waitForBoot(ValidateKbossVmCommand cmd, Domain vm) throws Libvir
return true;
}
} catch (LibvirtException ex) {
if (!ex.getMessage().contains(LibvirtComputingResource.AGENT_IS_NOT_CONNECTED)) {
if (!LibvirtComputingResource.AGENT_UNRESPONSIVE_ERROR_ORDINAL.equals(ex.getError().getCode().ordinal())) {

@JoaoJandre JoaoJandre Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to agree with the robot in this. Using the enum is much better then using the ordinal.

logger.error("Got an unexpected Libvirt Exception, giving up on validating VM [{}].", vm.getName(), ex);
throw ex;
}
Expand Down
Loading