conditional error reporting for vm move failure

[DaanHoogland]

Description

This PR...

Fixes: #13406

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.14%. Comparing base (549daae) to head (fb0c53c).

❗ There is a different number of reports uploaded between BASE (549daae) and HEAD (fb0c53c). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (549daae)	HEAD (fb0c53c)
unittests	1	0

Additional details and impacted files

@@              Coverage Diff              @@
##               4.20   #13675       +/-   ##
=============================================
- Coverage     16.26%    4.14%   -12.12%     
=============================================
  Files          5667      405     -5262     
  Lines        500731    33025   -467706     
  Branches      60803     5898    -54905     
=============================================
- Hits          81455     1370    -80085     
+ Misses       410172    31479   -378693     
+ Partials       9104      176     -8928     

Flag	Coverage Δ
uitests	4.14% <ø> (ø)
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

Adds a configurable way to return more informative API error messages when assignVirtualMachine (VM ownership change) fails, addressing the lack of actionable failure details reported in #13406.

Changes:

• Introduces a new global ConfigKey to control whether detailed assign/move failure reasons are exposed to API callers.
• Updates AssignVMCmd to optionally return InvalidParameterValueException messages to the caller when enabled.
• Registers the new ConfigKey in UserVmManagerImpl’s config key list.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java	Registers the new configuration key for VM-assign failure detail exposure.
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/AssignVMCmd.java	Conditionally returns a detailed failure reason from InvalidParameterValueException instead of only logging it.
api/src/main/java/com/cloud/vm/UserVmService.java	Defines the new global ConfigKey controlling detailed failure message exposure.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18663

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
6.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.