[WIP] Deprecate AppCookie (App session) based stickiness type policy for Virtual Router

[sureshanaparti]

Description

This PR deprecates AppCookie (App session) based stickiness type policy for Virtual Router, and some code improvements.

Fixes #3253

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

• Create VPC, network tier(s) and deploy instance on it.
• Acquire public IP and configure load balancing rule.
• On load balancing rule, configure sticky policy with 'AppCookie' method (this should fail with error).

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 25.00000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (549daae) to head (179dff6).

Files with missing lines	Patch %	Lines
...esource/virtualnetwork/VirtualRoutingResource.java	0.00%	13 Missing ⚠️
...ain/java/com/cloud/network/element/OvsElement.java	0.00%	1 Missing ⚠️
...loud/network/lb/LoadBalancingRulesManagerImpl.java	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #13315      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
- Complexity    13434    13437       +3     
============================================
  Files          5667     5667              
  Lines        500731   500724       -7     
  Branches      60803    60805       +2     
============================================
- Hits          81455    81445      -10     
  Misses       410172   410172              
- Partials       9104     9107       +3     

Flag	Coverage Δ
uitests	4.14% <ø> (ø)
unittests	17.12% <25.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

I think, a simple solution might be

cloudstack/server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java

Line 997 in 7308dad

} else if (LbStickinessMethod.StickinessMethodType.AppCookieBased.getName().equalsIgnoreCase(stickinessPolicy.getMethodName())) {

throwing an exception after this line

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18115

[sureshanaparti]

I think, a simple solution might be

cloudstack/server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java

Line 997 in 7308dad

} else if (LbStickinessMethod.StickinessMethodType.AppCookieBased.getName().equalsIgnoreCase(stickinessPolicy.getMethodName())) {

throwing an exception after this line

let me check it @weizhouapache

[weizhouapache]

@sureshanaparti
is this still WIP ?