Skip to content

Ensure VM IP is removed from VR DHCP records in dnsmasq.leases after expunge VM - #13194

Draft
sureshanaparti wants to merge 2 commits into
apache:4.20from
shapeblue:remove-vm-ip-from-dhcp-record-in-dnsmasq
Draft

Ensure VM IP is removed from VR DHCP records in dnsmasq.leases after expunge VM#13194
sureshanaparti wants to merge 2 commits into
apache:4.20from
shapeblue:remove-vm-ip-from-dhcp-record-in-dnsmasq

Conversation

@sureshanaparti

Copy link
Copy Markdown
Contributor

Description

This PR ensures VM IP is removed from VR DHCP records in dnsmasq.leases after expunge VM.

This also reverts the PR #10183 changes (for #10182), in turn resulting in #11877.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.26%. Comparing base (549daae) to head (df8df63).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #13194      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
+ Complexity    13434    13433       -1     
============================================
  Files          5667     5667              
  Lines        500731   500731              
  Branches      60803    60803              
============================================
- Hits          81455    81449       -6     
- Misses       410172   410176       +4     
- Partials       9104     9106       +2     
Flag Coverage Δ
uitests 4.14% <ø> (ø)
unittests 17.12% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread systemvm/debian/opt/cloud/bin/cs/CsDhcp.py Outdated
Comment thread systemvm/debian/opt/cloud/bin/cs/CsDhcp.py Outdated
@sureshanaparti

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@sureshanaparti sureshanaparti changed the title [WIP] Ensure VM IP is removed from VR DHCP records in dnsmasq.leases after expunge VM Ensure VM IP is removed from VR DHCP records in dnsmasq.leases after expunge VM Jun 25, 2026
@sureshanaparti sureshanaparti added this to the 4.20.4 milestone Jun 25, 2026
@DaanHoogland
DaanHoogland force-pushed the remove-vm-ip-from-dhcp-record-in-dnsmasq branch from 7742a9c to df8df63 Compare August 4, 2026 08:02
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@apache apache deleted a comment from blueorangutan Aug 4, 2026
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18760

@DaanHoogland

Copy link
Copy Markdown
Contributor

@sureshanaparti , is this ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows passwords cannot be set or reset when the system is on an isolated network with dual routers

4 participants