Don't allow adding of existing host to another zone, pod or cluster - #13182
Open
vishesh92 wants to merge 4 commits into
Open
Don't allow adding of existing host to another zone, pod or cluster#13182vishesh92 wants to merge 4 commits into
vishesh92 wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13182 +/- ##
============================================
- Coverage 16.26% 16.26% -0.01%
- Complexity 13434 13442 +8
============================================
Files 5667 5667
Lines 500731 500766 +35
Branches 60803 60810 +7
============================================
- Hits 81455 81449 -6
- Misses 410172 410214 +42
+ Partials 9104 9103 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
14 tasks
vishesh92
force-pushed
the
fix-add-host-diff-location
branch
from
May 18, 2026 12:06
2f64bcd to
6bf5881
Compare
Member
Author
|
@blueorangutan package |
Member
Author
|
@blueorangutan package |
vishesh92
marked this pull request as ready for review
May 19, 2026 08:10
Member
Author
|
@blueorangutan package |
Member
Author
|
@blueorangutan package |
Member
Author
|
@blueorangutan test |
winterhazel
reviewed
Jun 1, 2026
| if (existingPodId == null || existingClusterId == null) { | ||
| return; | ||
| } | ||
| if (existingDcId == dcId && Objects.equals(existingPodId, podId) && Objects.equals(existingClusterId, clusterId)) { |
Member
There was a problem hiding this comment.
Suggested change
| if (existingDcId == dcId && Objects.equals(existingPodId, podId) && Objects.equals(existingClusterId, clusterId)) { | |
| if (Objects.equals(existingDcId, dcId) && Objects.equals(existingPodId, podId) && Objects.equals(existingClusterId, clusterId)) { |
| if (existingDcId == dcId && Objects.equals(existingPodId, podId) && Objects.equals(existingClusterId, clusterId)) { | ||
| return; | ||
| } | ||
| final String identity = host.getUuid() != null ? host.getUuid() : host.getGuid(); |
Member
There was a problem hiding this comment.
Suggested change
| final String identity = host.getUuid() != null ? host.getUuid() : host.getGuid(); | |
| final String identity = ObjectUtils.defaultIfNull(host.getUuid(), host.getGuid()); |
potiuk
added a commit
to potiuk/cloudstack
that referenced
this pull request
Jun 17, 2026
- Q15: sensitive-file ownership root:cloud, mode 0640 - Q24: same-IP host re-add updates existing record, gated by creds + key/certs (apache#13182); not an unauthenticated spoof path - Q29: data-at-rest delegation to storage/hypervisor confirmed by vishesh92 Generated-by: Claude Opus 4.8
Member
|
@vishesh92 can you please address the remaining code review comments. |
Fixes apache#13080 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
DaanHoogland
force-pushed
the
fix-add-host-diff-location
branch
from
August 4, 2026 08:00
97e2f7b to
9228b5a
Compare
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18759 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #13080
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?