Reduce allocations in DefaultQueryOptions when read thresholds are en…#4883
Open
frankgh wants to merge 1 commit into
Open
Reduce allocations in DefaultQueryOptions when read thresholds are en…#4883frankgh wants to merge 1 commit into
frankgh wants to merge 1 commit into
Conversation
…abled patch by Francisco Guerrero; reviewed by TBD for CASSANDRA-21467
Contributor
|
technically we may get a case when a value is updated in the middle of a query execution and two subsequent get calls can give non-consistent results.. What is about keeping an instance of ReadThresholds on DatabaseDescriptor level as an object and replace it with a new one if values changed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…abled
patch by Francisco Guerrero; reviewed by TBD for CASSANDRA-21467