[CALCITE-7567] LeastRestrictiveSqlType for TIMESTAMP, TIMESTAMP_LTZ might ignore precision#4979
Merged
Merged
Conversation
mihaibudiu
reviewed
May 31, 2026
| } | ||
|
|
||
| if (type.getSqlTypeName() == resultType.getSqlTypeName() | ||
| if (type.getSqlTypeName().getFamily() == resultType.getSqlTypeName().getFamily() |
Contributor
There was a problem hiding this comment.
This may affect many more types than just TIMESTAMPs.
Contributor
Author
There was a problem hiding this comment.
can you elaborate on this please?
Asking since we are already inside this condition here
} else if (SqlTypeUtil.isDatetime(type)) {
...
}
mihaibudiu
approved these changes
May 31, 2026
Contributor
|
There's a typo in the subject. |
snuyanzin
changed the title
LeastRetrictiveSqlType for TIMESTAMP, TIMESTAMP_LTZ might ignore precisionLeastRestrictiveSqlType for TIMESTAMP, TIMESTAMP_LTZ might ignore precision
Contributor
Author
|
Thanks, |
mihaibudiu
added
the
LGTM-will-merge-soon
xuzifu666
approved these changes
Jun 2, 2026
…LTZ` might ignore precision
Contributor
Author
|
rebase to recent main before merging |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7567
Changes Proposed
The PR makes sure that leastRestrictive for TIMESTAMP(3) and TIMESTAMP_LTZ(0) will return result with same precision as for TIMESTAMP_LTZ(0) and TIMESTAMP_LTZ(3)