Make primary channel failover timeout configurable - #39646
Open
parveensania wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
@arunpandianp could you review this? Thanks. |
…y_not_ready_wait_nanos
arunpandianp
reviewed
Aug 5, 2026
arunpandianp
left a comment
arunpandianp
left a comment
Contributor
There was a problem hiding this comment.
Couple of minor comments. rest looks good to me.
arunpandianp
approved these changes
Aug 5, 2026
Contributor
Author
|
Run Java Dataflow Non-portable Worker PreCommit |
Contributor
Author
|
Run RAT PreCommit |
Contributor
|
Assigning reviewers: R: @Abacn added as fallback since no labels match configuration Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the timeout threshold before the
FailoverChannelswitches to a secondary (fallback) channel configurable.Previously, this wait time was hardcoded to 10 seconds. Making it configurable allows for easier tweaking and better control over failover behavior for directpath enabled jobs. The PR also increases the default from 10s to 15s.