[#38708] Add Flink 2.0 to SDK pipeline options validation lists#38726
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a validation mismatch where Flink 2.0 was not recognized as a valid version in the SDK pipeline options despite being supported by the runner. By updating the allowed version lists across the Python and TypeScript SDKs and the CI test properties, users can now successfully specify Flink 2.0 in their pipeline configurations. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for Flink version 2.0 by updating the supported and published Flink versions in the test properties, Python pipeline options, and TypeScript Flink runner configuration. No review comments were provided, so there is no feedback to address.
What does this PR do?
This PR fixes the Flink 2.0 CLI validation mismatch reported in #38708.
Beam 2.72.0 already includes Flink 2.0 runner support and the documentation reflects this, but the SDK option validation lists were not updated accordingly.
As a result, passing:
bash --flink_version 2.0
failed with:
text invalid choice: '2.0'
Changes
Added 2.0 to PUBLISHED_FLINK_VERSIONS in:
Updated default CI Flink version metadata:
Verification
Validated locally with:
bash python -c "from apache_beam.options.pipeline_options import PipelineOptions, FlinkRunnerOptions; opts = PipelineOptions(['--runner=FlinkRunner', '--flink_version=2.0']); print(opts.view_as(FlinkRunnerOptions).flink_version)"
which now parses successfully and returns:
text 2.0