Skip to content

[AURON #2459] Resolve build info paths relative to auron-build.sh #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShreyeshArangath wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[AURON #2459] Resolve build info paths relative to auron-build.sh #2461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions auron-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ run_docker_compose_up() {
exit 1
}

MVN_CMD="$(dirname "$0")/build/mvn"
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
MVN_CMD="$SCRIPT_DIR/build/mvn"

# -----------------------------------------------------------------------------
# Section: Initialize Variables
Expand Down Expand Up @@ -523,11 +524,20 @@ MVN_ARGS=("${CLEAN_ARGS[@]}" "${BUILD_ARGS[@]}")
# Description:
# Generate auron-build-info.properties for build metadata tracking.
# -----------------------------------------------------------------------------
BUILD_INFO_FILE="common/src/main/resources/auron-build-info.properties"
BUILD_INFO_FILE="$SCRIPT_DIR/common/src/main/resources/auron-build-info.properties"
mkdir -p "$(dirname "$BUILD_INFO_FILE")"

JAVA_VERSION=$(java -version 2>&1 | head -n 1 | awk '{print $3}' | tr -d '"')
PROJECT_VERSION=$(./build/mvn help:evaluate -N -Dexpression=project.version -Pspark-${SPARK_VER} -q -DforceStdout 2>/dev/null)
MVN_STDERR=$(mktemp)
if ! PROJECT_VERSION=$("$MVN_CMD" help:evaluate -N -f "$SCRIPT_DIR/pom.xml" -Dexpression=project.version -Pspark-${SPARK_VER} -q -DforceStdout 2>"$MVN_STDERR") \

@slfan1989 slfan1989 Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The version lookup is now pinned to the project POM, but the final Maven invocation below still runs without -f "$SCRIPT_DIR/pom.xml". When the script is invoked outside the repository, build-info generation succeeds, but the actual build still fails with MissingProjectException because Maven searches for a POM in the caller's directory. Please also pin the final Maven invocation to the project POM and add regression coverage for running the complete local build from another directory.

|| [[ ! "$PROJECT_VERSION" =~ ^[A-Za-z0-9._-]+$ ]]; then
echo "[ERROR] Failed to resolve project.version using $MVN_CMD" >&2
[[ -n "$PROJECT_VERSION" ]] && echo "[ERROR] stdout was: $PROJECT_VERSION" >&2
sed 's/^/[ERROR] /' "$MVN_STDERR" >&2
rm -f "$MVN_STDERR"
exit 1
fi
rm -f "$MVN_STDERR"
RUST_VERSION=$(rustc --version | awk '{print $2}')

get_build_info() {
Expand Down
Loading