ARTEMIS-6099 Add log message when configuration reload is complete#6499
ARTEMIS-6099 Add log message when configuration reload is complete#6499rii13024 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an explicit INFO log indicating configuration reload completion and covers it with an integration test to ensure the completion signal is emitted exactly once.
Changes:
- Emit a new server log event (
AMQ221087) when configuration reload finishes. - Add an integration test that reloads broker config and asserts the completion log is produced.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/RedeployTest.java | Adds an integration test asserting a “reload completed” log is emitted once. |
| artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java | Hooks the new completion log into the reload flow (and adjusts reload sequencing). |
| artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java | Introduces a new log message ID and method for “Configuration reload completed”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ling whitespace in logger, add proper async wait in test using Wait.assertTrue()
| configurationReloadDeployed.set(false); | ||
| if (isActive()) { | ||
| deployReloadableConfigFromConfiguration(); | ||
| ActiveMQServerLogger.LOGGER.configurationReloadCompleted(); |
There was a problem hiding this comment.
I think this should be the last line in deployReloadableConfigFromConfiguration(), in side the if that flips the configurationReloadDeployed boolean. Check the callers, there is a path to deployReloadableConfigFromConfiguration from startup that we need to capture.
There was a problem hiding this comment.
Summary:
Adds a new INFO-level log message (AMQ221087) that is emitted when the entire configuration reload operation completes.
Problem:
Currently, the broker logs individual configuration reload steps (AMQ221056) but does not log when the entire reload operation completes. This makes it difficult to determine when the broker is ready for status checks after a configuration reload.
Changes:
AMQ221087: Configuration reload completedinActiveMQServerLoggerActiveMQServerImpl.reloadConfigurationFile()after all reload operations finishRedeployTest.testReloadCompletion()to verify the log message appears exactly onceTesting: