GH-44183: [C++][Python] Support run-end encoded struct and list values#50534
Open
BenMagyar wants to merge 2 commits into
Open
GH-44183: [C++][Python] Support run-end encoded struct and list values#50534BenMagyar wants to merge 2 commits into
BenMagyar wants to merge 2 commits into
Conversation
Adding the encode path for nested-value encoding for List, FixedSizeList and Struct arrays
Adding the decode path for nested-value encoding for List, FixedSizeList and Struct arrays
|
|
BenMagyar
changed the title
|
|
BenMagyar
changed the title
|
|
1 similar comment
|
|
BenMagyar
changed the title
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
From #44183 - creating run-end encoded cols that contain list or struct values is unsupported. Adding support for both the encode and decode paths.
What changes are included in this PR?
List,FixedSizeListandStructvalues in therun_end_encodeand therun_end_decodepaths.Are these changes tested?
Are there any user-facing changes?
There are but they are not breaking. Currently the encode path throws that it is unsupported on one of these types. We are adding support.