Skip to content

MINOR: [R] progress towards removing Assertthat dependency #50525

Open
olivroy wants to merge 10 commits into
apache:mainfrom
olivroy:assert
Open

MINOR: [R] progress towards removing Assertthat dependency #50525
olivroy wants to merge 10 commits into
apache:mainfrom
olivroy:assert

Conversation

@olivroy

@olivroy olivroy commented Jul 16, 2026

Copy link
Copy Markdown

Rationale for this change

To get rid of assertthat dependency

What changes are included in this PR?

  • progress towards removing assertthat dependency (replaced by rlang's type checkers)

Are these changes tested?

By existing tests.

Are there any user-facing changes?

No, only error messages standardized.

I have not been able to install the dev version locally, so I would need the workflows to be run, so that I could adjust the tests.

@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@olivroy olivroy changed the title [R] remove Assertthat dependency MINOR: [R] progress towards removing Assertthat dependency Jul 16, 2026
@olivroy
olivroy marked this pull request as ready for review July 17, 2026 12:19
@olivroy

olivroy commented Jul 17, 2026

Copy link
Copy Markdown
Author

Still a draft, but wanted to ping for you to activate the workflow run, so I could see the test results, so I could adjust them.

@thisisnic

Copy link
Copy Markdown
Member

Thanks for the PR @olivroy! Can you expand more about trying to get the dev version working locally - what have you tried and what errors are you getting? It'll be easier if we help you with that first, as building iteratively on CI burns through a lot of machine time and is a really frustrating process as you wait for the builds to complete which takes much longer than just running devtools::test() once your setup is working.

@olivroy

olivroy commented Jul 17, 2026

Copy link
Copy Markdown
Author

I understand.. I am not very good with that. but when I call devtools::load_all(), I get this

── R CMD INSTALL ───────────────────────────────────────────────────────────────
─  installing *source* package 'arrow' ... (1.5s)
   ** this is package 'arrow' version '25.0.0.9000'
   ** using staged installation
   *** pkg-config found.
   *** No nightly binaries were found for version 25.0.0.9000: falling back to libarrow build from source
   *** Unable to retrieve libarrow for version 25.0.0.9000 (windows-x86_64)
   *** Proceeding without libarrow (build not authorized)
   Arrow C++ library was not found
   ------------------------- NOTE ---------------------------
   There was an issue preparing the Arrow C++ libraries.
   See https://arrow.apache.org/docs/r/articles/install.html

I don't know much about compilation...

@thisisnic

Copy link
Copy Markdown
Member

*** Unable to retrieve libarrow for version 25.0.0.9000 (windows-x86_64)

Thanks, that's helpful! It looks like there's an issue with our nightly C++ builds, so actually while we're fixing that then we can probably only easily build on CI so that's fine for now. This is super useful to know though, will have a look at getting it fixed.

Once it is fixed, I think that setting the ARROW_R_DEV environment variable to TRUE will enabled you to use the nightly builds easily: Sys.setenv(ARROW_R_DEV = "true")

@olivroy

olivroy commented Jul 17, 2026

Copy link
Copy Markdown
Author

Oh, this is great! Thanks for investigating and finding a fix! This will be useful in the future.

Hopefully, I got everything corrected this time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants