Add option to build and serve posts with dates in the future#774
Open
ianmcook wants to merge 2 commits into
Open
Add option to build and serve posts with dates in the future#774ianmcook wants to merge 2 commits into
ianmcook wants to merge 2 commits into
Conversation
|
Preview URL: https://ianmcook.github.io/arrow-site If the preview URL doesn't work, you may forget to configure your fork repository for preview. |
ianmcook
changed the title
lidavidm
approved these changes
Apr 7, 2026
lidavidm
left a comment
lidavidm
left a comment
Member
There was a problem hiding this comment.
Is there any reason not to do this for a local server? Feels like it'd be easier to just always enable it
Member
Author
|
Hmm, good question. Someone might have a reason, I suppose, but I can't think of an obvious one. |
kou
reviewed
Apr 8, 2026
kou
left a comment
kou
left a comment
Member
There was a problem hiding this comment.
Let's enable --future by default.
Member
Author
Done in a08e969 |
lidavidm
approved these changes
Apr 8, 2026
lidavidm
reviewed
Apr 8, 2026
kou
approved these changes
Apr 8, 2026
Comment on lines
+61
to
+62
| future = ENV["JEKYLL_FUTURE"] | ||
| command_line << "--future" if future |
Member
There was a problem hiding this comment.
We can simplify this:
Suggested change
| future = ENV["JEKYLL_FUTURE"] | |
| command_line << "--future" if future | |
| command_line << "--future" if ENV["JEKYLL_FUTURE"] |
BTW, do we need this? If we need this, how about enable this only for preview?
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index 9b963f13831..86236479f95 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -64,6 +64,9 @@ jobs:
export JEKYLL_DESTINATION=../build
export JEKYLL_ENV=production
export JEKYLL_EXTRA_CONFIG=_extra_config.yml
+ if [ "${GITHUB_REPOSITORY}" != "apache/arrow-site" ]; then
+ export JEKYLL_FUTURE=1
+ fi
bundle exec rake generate
- name: Checkout asf-site
uses: actions/checkout@v6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.