ci: run clippy for arrow-pyarrow - #10758
Merged
Merged
Conversation
It is the only published crate in the workspace without a clippy run. The step goes in the pyarrow integration job rather than arrow.yml's clippy job, which runs in a container with no interpreter for pyo3 to link against. Closes apache#10757.
alamb
reviewed
Aug 19, 2026
alamb
approved these changes
Aug 19, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this @Lstarsky0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10757.
Rationale for this change
Continuing from #10724, which added the missing test and clippy steps for
arrow-cmp.arrow-pyarrowwas the other one, and it's the last published crate in the workspace with no clippy run at all.What changes are included in this PR?
One step in
integration.yml'sPyarrow C Data Interfacejob, after the Rust tests and inside the same venv.It goes there rather than in
arrow.yml's clippy job, where the rest of thearrow-*crates are linted, because that job runs in theamd64/rustcontainer and pyo3 needs an interpreter to link against. This job already has one, and its toolchain step already installs clippy without using it.Two invocations instead of the four
arrow.ymlruns per crate:arrow-pyarrowdeclares nodefaultfeature, so the bare and--no-default-featuresforms of the dependency check are the same command as--all-features.Are these changes tested?
Both commands pass on
mainas written, so nothing goes red on merge — the point is that a future warning will. I ran them under a fresh venv the way the job does, and dropped a probe lint intoarrow-pyarrow/src/lib.rsto confirm the step fails rather than passing vacuously.One thing I'd rather you decided: the job is a three-way matrix over pyarrow 15/16/17, and the lint result doesn't depend on which one, so this runs three times for the same answer. I left it that way because gating a step on a matrix value isn't a pattern used anywhere else in these workflows, but a standalone clippy job — only needing
setup-python, not the venv or pyarrow itself — would run it once, and I'm happy to send that instead.