parquet: Add new PageIndex struct to encapsulate column and offset indexes - #10719
Open
etseidl wants to merge 21 commits into
Open
parquet: Add new PageIndex struct to encapsulate column and offset indexes#10719etseidl wants to merge 21 commits into
PageIndex struct to encapsulate column and offset indexes#10719etseidl wants to merge 21 commits into
Conversation
Contributor
Author
etseidl
commented
Aug 17, 2026
| /// [PageIndex documentation]: https://github.com/apache/parquet-format/blob/master/PageIndex.md | ||
| /// [`OffsetIndex`]: https://github.com/apache/parquet-format/blob/master/PageIndex.md | ||
| pub type ParquetOffsetIndex = Vec<Vec<OffsetIndexMetaData>>; | ||
| impl PageIndex { |
Contributor
Author
There was a problem hiding this comment.
TODO: better documentation
etseidl
force-pushed
the
new_page_index
branch
from
August 18, 2026 16:42
49cbf86 to
7f47fac
Compare
Contributor
|
Shal I give this one a look? |
Contributor
Author
Yes please. I think there's a todo left and it needs some better docs, but if you could take a look and see if you think this is the direction you wanted to head I'd appreciate it. |
Contributor
|
Thank you -- I will do so but probably not until tomorrow (I need a clear mind) |
etseidl
marked this pull request as ready for review
August 19, 2026 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ParquetMetaData#8818.Note: this is stacked on #10653
Rationale for this change
Following up on #10653 (review)
What changes are included in this PR?
Try to hide some of the complexity of the page indexes behind a struct with accessors for access by row group, or row group and column.
Are these changes tested?
Should be covered by existing
Are there any user-facing changes?
Yes, this changes the public interface to the page indexes quite a bit.