bench(parquet): cover large dictionary values in arrow_reader - #10691
Merged
Conversation
AarryaSaraf
force-pushed
the
bench-dict-large-values
branch
from
August 14, 2026 23:27
e8afe4d to
142cc80
Compare
AarryaSaraf
marked this pull request as ready for review
August 15, 2026 00:19
Contributor
|
run benchmark arrow_reader env:
BENCH_FILTER: large values |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing bench-dict-large-values (142cc80) to b5794fb (merge-base) diff Run configurationrun benchmark arrow_reader
env:
BENCH_FILTER: "large values"BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing bench-dict-large-values (142cc80) to b5794fb (merge-base) diff Run configurationrun benchmark arrow_reader
env:
BENCH_FILTER: "large values"CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Contributor
|
thanks @AarryaSaraf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None. This is benchmark coverage split out of #10690, so that the change
proposed there can be measured against a benchmark that already exists on
main.It covers the shape reported in #10694.
Rationale for this change
Every dictionary-encoded case in
arrow_readerdecodes ~20 byte values:build_dictionary_encoded_string_page_iteratorbuilds"Dictionary value {x}"at 1% unique. Two properties of that shape keep the dictionary gather out of the
measurement entirely — values are small enough that per-key overhead dominates
(RLE index decoding, the per-key bounds check), and the dictionary is a couple of
KiB, so it stays cached for the whole decode.
Columns of large binary payloads invert both. A writer's dictionary size limit is
checked lazily, so such a column is often dictionary encoded all the way to the
end, with the dictionary page holding the entire column and each entry referenced
exactly once. The gather then gets its data from a source far too large to cache,
and it is the gather rather than the per-key work that dominates.
No benchmark in the crate covers that, so changes to
OffsetBuffer::extend_from_dictionarycurrently have nothing to be measuredagainst.
What changes are included in this PR?
One generator and one case in the existing
BinaryArraygroup:build_dictionary_encoded_large_value_page_iterator— 64 KiB values, alldistinct, 128 per page, mandatory (no NULLs), otherwise the same row-group and
page geometry as the existing generators.
arrow_array_reader/BinaryArray/dictionary encoded, mandatory, no NULLs, large valuesOne iteration decodes 64 MiB of output from a 32 MiB dictionary. Measured on
main(Apple M-series):Are these changes tested?
This is a benchmark. It asserts its decoded value count on each run, as the
surrounding cases do.
Are there any user-facing changes?
No.
AI disclosure
This benchmark was drafted with AI assistance and reviewed by me.