test: cover signed integers and bool in BitReader::get_batch test#10180
Merged
Conversation
`test_get_batch` only exercised the unsigned types (`u8`/`u16`/`u32`/`u64`). `BitReader::get_batch` is generic over the signed integer types and `bool` as well, each with its own `FromBitpacked` implementation, but none of those were covered by the test. Extend the test to also run the signed counterpart of each width and `bool` (at its only supported bit width of 1). This locks in coverage for those code paths, which is especially relevant given that `parquet` is not part of the MIRI CI workflow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
test_get_batchinparquet/src/util/bit_util.rsonly exercised the unsignedtypes (
u8/u16/u32/u64).BitReader::get_batchis also generic over thesigned integer types (
i8/i16/i32/i64) andbool, each with its ownFromBitpackedimplementation, but none of those were covered by the test.What changes are included in this PR?
Extend
test_get_batchto also run the signed counterpart of each width andbool(at its only supported bit width of 1), reusing the existingtest_get_batch_helper.Are these changes tested?
it is all testes
Are there any user-facing changes?
No.