[arrow-select] perf: Replace ArrayData with direct Array construction in take kernels#10176
Open
liamzwbao wants to merge 1 commit into
Open
[arrow-select] perf: Replace ArrayData with direct Array construction in take kernels#10176liamzwbao wants to merge 1 commit into
ArrayData with direct Array construction in take kernels#10176liamzwbao wants to merge 1 commit into
Conversation
…tion in take kernels
Contributor
Author
|
Hi @alamb, this PR is ready for review. Would appreciate a benchmark on |
Contributor
|
run benchmark take_kernels |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing issue-9298-take-array-data (e2aa396) to b79d20d (merge-base) diff File an issue against this benchmark runner |
Jefffrey
approved these changes
Jun 22, 2026
Jefffrey
left a comment
Jefffrey
left a comment
Contributor
There was a problem hiding this comment.
is this the final piece of work to close the original issue?
| Ok(Arc::new(MapArray::from(unsafe { builder.build_unchecked() }))) | ||
| let (_, offsets, entries, nulls) = list_data.into_parts(); | ||
| let entries = entries.as_struct().clone(); | ||
| Ok(Arc::new(MapArray::try_new( |
Contributor
There was a problem hiding this comment.
i suppose the checks inside try_new are cheap enough to not be too much of an impact 👍
Contributor
There was a problem hiding this comment.
I suggest we switch back to MapArray::new_unchecked
|
|
||
| let list_data = unsafe { list_data.build_unchecked() }; | ||
| Ok(GenericListArray::<OffsetType::Native>::from(list_data)) | ||
| GenericListArray::<OffsetType::Native>::try_new(field, offsets, child, nulls) |
Contributor
There was a problem hiding this comment.
yeah, as above I think we should use new_unchecked
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Contributor
|
run benchmark take_kernels |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing issue-9298-take-array-data (e2aa396) to b79d20d (merge-base) diff File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Contributor
|
there seems to be an impact on stringview benchmark 🤔 |
alamb
reviewed
Jun 22, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
there seems to be an impact on stringview benchmark 🤔
We may be hitting some sort of allocator thing again, as I don't think this PR changes any of the string view array code 🤔
arrow-rs/arrow-select/src/take.rs
Lines 637 to 641 in e2aa396
| Ok(Arc::new(MapArray::from(unsafe { builder.build_unchecked() }))) | ||
| let (_, offsets, entries, nulls) = list_data.into_parts(); | ||
| let entries = entries.as_struct().clone(); | ||
| Ok(Arc::new(MapArray::try_new( |
Contributor
There was a problem hiding this comment.
I suggest we switch back to MapArray::new_unchecked
|
|
||
| let list_data = unsafe { list_data.build_unchecked() }; | ||
| Ok(GenericListArray::<OffsetType::Native>::from(list_data)) | ||
| GenericListArray::<OffsetType::Native>::try_new(field, offsets, child, nulls) |
Contributor
There was a problem hiding this comment.
yeah, as above I think we should use new_unchecked
alamb
approved these changes
Jun 22, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @liamzwbao and @Jefffrey
| Ok(Arc::new(MapArray::from(unsafe { builder.build_unchecked() }))) | ||
| let (_, offsets, entries, nulls) = list_data.into_parts(); | ||
| let entries = entries.as_struct().clone(); | ||
| Ok(Arc::new(MapArray::try_new( |
Contributor
|
i mistook genericlistview in the diff for stringview 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ArrayDatawith direct Array construction, when possible #9298.Rationale for this change
What changes are included in this PR?
Replaces several
ArrayDataBuilderpaths inarrow-select/src/filter.rswith direct typed array constructors.Are these changes tested?
Covered by existing tests.
Are there any user-facing changes?
No