fix: switch generic usages of i128 to IntervalMonthDayNano for MonthDayNano type#10171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
MutableArrayData::newexpects a large alignment forIntervalMonthDayNanoTypearrays #5917Rationale for this change
Some functions were still using
i128for generic type in relation to monthdaynano type, which is incorrect sincei128has an alignment of 16 whilst actualIntervalMonthDayNanotype only has 8; this mismatch can cause panics on certain code paths.What changes are included in this PR?
Switch usage of
i128toIntervalMonthDayNanoAre these changes tested?
Test from original issue.
Are there any user-facing changes?
No.