fix: add integer overflow checks for arithmetic operations - #2482
Open
mmustafasenoglu wants to merge 2 commits into
Open
fix: add integer overflow checks for arithmetic operations#2482mmustafasenoglu wants to merge 2 commits into
mmustafasenoglu wants to merge 2 commits into
Conversation
Add overflow/underflow detection for 64-bit integer arithmetic in agtype_add, agtype_sub, agtype_mul, agtype_neg, agtype_div, and agtype_mod operations. Previously, operations like 9223372036854775807 + 1 silently wrapped around to -9223372036854775808 instead of raising an error. This matches Neo4j and PostgreSQL behavior which reject integer overflow. Fixes apache#2471 Signed-off-by: Mustafa Senoglu <mmustafasenoglu0@gmail.com>
mmustafasenoglu
force-pushed
the
fix/integer-overflow-checks
branch
from
July 29, 2026 12:37
7e5450e to
f62d6ab
Compare
…rflow The previous check compared float_value == (double)PG_INT64_MIN, but the parser stores 9223372036854775808 as a positive float (AGTV_FLOAT), so the comparison with the negative PG_INT64_MIN was always false. Fix: compare float_value == -(double)PG_INT64_MIN to match the positive float representation. Also adds division and modulo overflow checks for INT64_MIN / -1. Signed-off-by: Mustafa Senoglu <mmustafasenoglu0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds overflow/underflow detection for 64-bit integer arithmetic in agtype operations.
Problem
Integer arithmetic silently wraps around on overflow instead of raising an error:
Both PostgreSQL and Neo4j reject these with errors.
Fix
Uses GCC/Clang intrinsics to detect overflow in:
Each raises on overflow.
Tests
Added 6 regression tests covering each overflow case.
Fixes #2471