Unified --Json output#6419
Open
ArbaazKhan1 wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
What the Json output would look like for `accumulo inst service-status --json {
"command": "accumulo admin service-status",
"version": "1.0",
"reportTime": "2026-06-09T20:20:01Z",
"status": "OK",
"data": {
"reportTime": "2026-06-09T20:20:01.889Z",
"zkReadErrors": 0,
"showHosts": false,
"summaries": {
"COMPACTOR": {
"resourceGroups": {
"default": 1
},
"serviceByGroups": {
"default": [
"localhost:9600"
]
},
"serviceCount": 1,
"errorCount": 0
},
"GC": {
"resourceGroups": {
"default": 1
},
"serviceByGroups": {
"default": [
"localhost:9998"
]
},
"serviceCount": 1,
"errorCount": 0
},
"MANAGER": {
"resourceGroups": {
"default": 1
},
"serviceByGroups": {
"default": [
"localhost:9999"
]
},
"serviceCount": 1,
"errorCount": 0
},
"MONITOR": {
"resourceGroups": {
"default": 1
},
"serviceByGroups": {
"default": [
"localhost:9995"
]
},
"serviceCount": 1,
"errorCount": 0
},
"S_SERVER": {
"resourceGroups": {
"default": 1
},
"serviceByGroups": {
"default": [
"localhost:9700"
]
},
"serviceCount": 1,
"errorCount": 0
},
"T_SERVER": {
"resourceGroups": {
"default": 1
},
"serviceByGroups": {
"default": [
"localhost:9800"
]
},
"serviceCount": 1,
"errorCount": 0
}
}
}
} |
dlmarion
reviewed
Jun 22, 2026
| * "reportTime": "2026-06-04T12:00:00Z", | ||
| * "status": "OK", | ||
| * "message": null, | ||
| * "data": { ...command-specific payload... } |
Contributor
There was a problem hiding this comment.
I wonder if the command output should be it's own top level element instead. For example,
{
"status": {
"command": "accumulo admin fate --summary",
"version": "1",
"reportTime": "2026-06-04T12:00:00Z",
"status": "OK",
"message": ""
},
"output": {
}
}
Comment on lines
+78
to
+79
| this.status = status; | ||
| this.message = message; |
Contributor
There was a problem hiding this comment.
Might be able to combine these two fields into one. For success the value could be OK. For a failure the value could be ERROR: <message>
Comment on lines
+59
to
+60
| private static final DateTimeFormatter ISO_FMT = | ||
| DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss'Z'"); |
Contributor
There was a problem hiding this comment.
I wonder if it would be more user friendly to use the hosts timezone.
|
|
||
| if (options.json) { | ||
| System.out.println(report.toJson()); | ||
| System.out.println(report.toEnvelopedJson("accumulo admin service-status")); |
Contributor
There was a problem hiding this comment.
It might make sense to add a method to ServerKeywordExecutable that returns the invoked command. This would make this more flexible if the command group or command name changes in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses issue #6391
To make a universal
--jsonflag I moved it fromFateandServiceStatusand intoServerOptsso all commands inherit it. Added a newCommandOutputEnvelopeclass that will take accumulo JSON outputs and wraps them in an envelope for a unified output and a newCommandReportinterface that report classes will inherit so they can produce both human-readable and computer readable lines. Started by wiring upfate --summaryandservice-statusas the two proof-of-concept commands since both already have partial JSON support