Skip to content

fix: guard against bare unparameterized dict/list in construct_type and transform #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiankhooban wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −5
Open

fix: guard against bare unparameterized dict/list in construct_type and transform #1639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab9f0ee
fix: guard against bare unparameterized dict/list in construct_type a…
kiankhooban Jun 3, 2026
26eea24
fixup: address Copilot review comments on _transform.py
kiankhooban Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/anthropic/_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ def construct_type(*, value: object, type_: object, metadata: Optional[List[Any]
if not is_mapping(value):
return value

_, items_type = get_args(type_) # Dict[_, items_type]
items_type = args[1] if len(args) >= 2 else object # Dict[_, items_type]
return {key: construct_type(value=item, type_=items_type) for key, item in value.items()}

if (
Expand All @@ -668,7 +668,7 @@ def construct_type(*, value: object, type_: object, metadata: Optional[List[Any]
if not is_list(value):
return value

inner_type = args[0] # List[inner_type]
inner_type = args[0] if args else object # List[inner_type]
return [construct_type(value=entry, type_=inner_type) for entry in value]

if origin == float:
Expand Down
8 changes: 5 additions & 3 deletions src/anthropic/_utils/_transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@ def _transform_recursive(
return _transform_typeddict(data, stripped_type)

if origin == dict and is_mapping(data):
items_type = get_args(stripped_type)[1]
args = get_args(stripped_type)
items_type = args[1] if len(args) >= 2 else object
return {key: _transform_recursive(value, annotation=items_type) for key, value in data.items()}

if (
Expand Down Expand Up @@ -346,8 +347,9 @@ async def _async_transform_recursive(
return await _async_transform_typeddict(data, stripped_type)

if origin == dict and is_mapping(data):
items_type = get_args(stripped_type)[1]
return {key: _transform_recursive(value, annotation=items_type) for key, value in data.items()}
args = get_args(stripped_type)
items_type = args[1] if len(args) >= 2 else object
return {key: await _async_transform_recursive(value, annotation=items_type) for key, value in data.items()}

if (
# List[T]
Expand Down