v5: Mark Scalar obsolete#1681
Draft
angularsen wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Scalaris planned for removal in v6 because it is a unitless value wrapper rather than a physical quantity. It was originally added in #889 for #849 as a way to put plain counts/values into anIQuantityshape, but it has not grown meaningful semantic usage in the codebase.This v5 PR keeps the API intact while warning callers ahead of the v6 breaking removal in #1680.
Changes
ObsoleteTexttoCommon/UnitDefinitions/Scalar.json.Scalarquantity, nanoFramework quantity, and number extensions so callers see[Obsolete]warnings.Validation
dotnet run --project CodeGen -p:NuGetAudit=falsedotnet build UnitsNet.sln -p:NuGetAudit=falsedotnet test UnitsNet.Tests -f net48 -p:NuGetAudit=falsedotnet test UnitsNet.Tests -f net9.0 -p:NuGetAudit=falsedotnet test UnitsNet.NumberExtensions.Tests -p:NuGetAudit=falseNote:
generate-code.bat/plain restore on this maintenance branch is currently blocked by a NuGet audit warning forNuGet.Protocol6.12.1, so validation usedNuGetAudit=falseto avoid changing dependencies in this deprecation PR.Refs #849, #1200, #1679, #1680.