Skip to content

Remove fakeAsync from popover tests#33300

Merged
crisbeto merged 2 commits into
angular:mainfrom
crisbeto:popover-edit-fake-async
May 27, 2026
Merged

Remove fakeAsync from popover tests#33300
crisbeto merged 2 commits into
angular:mainfrom
crisbeto:popover-edit-fake-async

Conversation

@crisbeto
Copy link
Copy Markdown
Member

Updates the popover tests not to use fakeAsync anymore.

@crisbeto crisbeto added merge: preserve commits When the PR is merged, a rebase and merge should be performed target: rc This PR is targeted for the next release-candidate labels May 23, 2026
@pullapprove pullapprove Bot requested review from tjshiu and wagnermaciel May 23, 2026 07:20
@crisbeto crisbeto force-pushed the popover-edit-fake-async branch from c66d42f to accef33 Compare May 23, 2026 07:57
crisbeto added 2 commits May 23, 2026 10:03
…fakeAsync

Reworks the tests not to depend on `fakeAsync`.
…sync

Reworks the tests not to depend on `fakeAsync`.
@crisbeto crisbeto force-pushed the popover-edit-fake-async branch from accef33 to c0d4590 Compare May 23, 2026 08:05
@crisbeto crisbeto requested a review from ok7sai May 27, 2026 07:50
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 27, 2026
@crisbeto crisbeto merged commit e973652 into angular:main May 27, 2026
30 of 31 checks passed
@crisbeto
Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker merge: preserve commits When the PR is merged, a rebase and merge should be performed target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants