fix(@angular/cli): expand package groups for newly added peer dependencies in update schematic#33269
Merged
Merged
Conversation
…ncies in update schematic Previously, the package group stabilization loop ran completely before the peer dependencies resolution loop. If a peer dependency was newly added during the peer dependencies loop (e.g., @angular/core), its corresponding package group members (e.g., @angular/router) were never expanded, leaving them at outdated versions. Now, wrap the package group and peer dependencies stabilization logic in a single outer loop so that newly added peer dependencies are also stabilized and their package groups are correctly expanded.
alan-agius4
added
target: patch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the package update schematic to nest the package group resolution loop inside the peer dependencies resolution loop. This change ensures that any new peer dependencies introduced during an iteration can correctly trigger the resolution of their corresponding package groups in subsequent iterations, preventing incomplete dependency resolution. There are no review comments, and I have no feedback to provide.
clydin
approved these changes
May 29, 2026
alan-agius4
added
action: merge
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the package group stabilization loop (
_addPackageGroup) ran completely before the peer dependencies resolution loop (_addPeerDependencies). If a peer dependency was newly added during the peer dependencies loop (such as@angular/corewhen updating@angular/build), its corresponding package group members (such as@angular/routerand@angular/common) were never expanded, leaving them outdated.Now, we wrap the package group and peer dependencies stabilization logic in a single outer loop so that newly added peer dependencies also get their package groups correctly stabilized and expanded.