Skip to content

Upgrade Camera2SlowMotion#635

Open
rodrigomologni wants to merge 8 commits into
android:mainfrom
rodrigomologni:upgrade/Camera2SlowMotion
Open

Upgrade Camera2SlowMotion#635
rodrigomologni wants to merge 8 commits into
android:mainfrom
rodrigomologni:upgrade/Camera2SlowMotion

Conversation

@rodrigomologni
Copy link
Copy Markdown

This PR upgrades the Camera2SlowMotion sample to ensure compatibility with the latest Android SDK.

Key changes:

  • Refactored or replaced legacy and deprecated Java elements to improve pipeline stability and code health.
  • Fully tested the high-speed recording pipeline on physical hardware (Samsung Galaxy A53) to ensure it works perfectly.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 26, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project to target Android SDK 37, bumps Gradle, Kotlin, and various dependencies, and modernizes several APIs. Key changes include migrating to WindowInsetsCompat for full-screen handling, using ActivityResultContracts for permissions, and adopting the modern createCaptureSession API with SessionConfiguration. The review feedback identifies a critical compilation error in SelectorFragment.kt due to an incorrect import for findNavController(), and suggests restricting the visibility of navigateToSelectorFragment in PermissionsFragment.kt to private for better encapsulation.

Comment on lines 60 to 62
fun navigateToSelectorFragment() {
findNavController().navigate(PermissionsFragmentDirections.actionPermissionsToSelector())
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The function navigateToSelectorFragment is only used internally within PermissionsFragment and should be marked as private to restrict its visibility and improve encapsulation.

    private fun navigateToSelectorFragment() {\n        findNavController().navigate(PermissionsFragmentDirections.actionPermissionsToSelector())\n    }

rodrigomologni and others added 2 commits May 26, 2026 13:59
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant