Upgrade Camera2SlowMotion#635
Conversation
- Replace elements deprecated in Java
- Replace elements deprecated in Java
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the project to target Android SDK 37, bumps Gradle, Kotlin, and various dependencies, and modernizes several APIs. Key changes include migrating to WindowInsetsCompat for full-screen handling, using ActivityResultContracts for permissions, and adopting the modern createCaptureSession API with SessionConfiguration. The review feedback identifies a critical compilation error in SelectorFragment.kt due to an incorrect import for findNavController(), and suggests restricting the visibility of navigateToSelectorFragment in PermissionsFragment.kt to private for better encapsulation.
| fun navigateToSelectorFragment() { | ||
| findNavController().navigate(PermissionsFragmentDirections.actionPermissionsToSelector()) | ||
| } |
There was a problem hiding this comment.
The function navigateToSelectorFragment is only used internally within PermissionsFragment and should be marked as private to restrict its visibility and improve encapsulation.
private fun navigateToSelectorFragment() {\n findNavController().navigate(PermissionsFragmentDirections.actionPermissionsToSelector())\n }Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This PR upgrades the
Camera2SlowMotionsample to ensure compatibility with the latest Android SDK.Key changes: