Merge node-pr.yml's install job into build and test#166
Merged
tmthrgd-aligent merged 1 commit intoJul 2, 2026
Merged
Conversation
Previously node-pr.yml worked in three stages. It would start by running an install job that would download and archive all node dependencies. It would then, in parallel, run separate build and test jobs that would start by installing node again and unpacking those dependencies. This packing and unpacking step routinely took longer than the download did. It also consumes artifact storage space, which has caused persistent pipeline failures on one of our client hosted projects. It also resulted in a lot of logic duplicated in three separate places. Instead of all of this, we'll merge the install job into both the build and test jobs, and just download the node dependencies twice. This will actually result in faster pipeline runs approximately always. It also gives us the advantage of having safe-chain installed in both build and test jobs. This could be advantageous if future changes were to see them run additional installs, or if they commands they execute from package.json were to run any install commands.
Contributor
Author
|
Have run a few tests against other repos and it fixes the Polyaire breakage as hoped. PolyaireDev/polyaire-frontend: https://github.com/PolyaireDev/polyaire-frontend/pull/20. Action time goes from ~4:45 to ~4:00. (Failure is unrelated). |
AdamJHall
approved these changes
Jul 2, 2026
tmthrgd-aligent
deleted the
fix/DO-1765_merge_node_install_job_into_build_and_test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously node-pr.yml worked in three stages. It would start by running an install job that would download and archive all node dependencies. It would then, in parallel, run separate build and test jobs that would start by installing node again and unpacking those dependencies.
This packing and unpacking step routinely took longer than the download did. It also consumes artifact storage space, which has caused persistent pipeline failures on one of our client hosted projects.
It also resulted in a lot of logic duplicated in three separate places.
Instead of all of this, we'll merge the install job into both the build and test jobs, and just download the node dependencies twice. This will actually result in faster pipeline runs approximately always.
It also gives us the advantage of having safe-chain installed in both build and test jobs. This could be advantageous if future changes were to see them run additional installs, or if they commands they execute from package.json were to run any install commands.