-
Notifications
You must be signed in to change notification settings - Fork 19
[docs-agent] Split Sui gRPC streaming methods into a bandwidth-priced section #1518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
alchemy-bot
wants to merge
2
commits into
main
Choose a base branch
from
docs/sui-grpc-streaming-cu-section
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence starts advertising and pricing five Sui gRPC methods that the linked Alchemy Sui gRPC overview/API reference does not expose (
SubscribeTransactions,SubscribeEvents,ListCheckpoints,ListTransactions, andListEvents); I checked the Sui gRPC docs in this repo andrgshows those names only in this new pricing line. When customers follow the pricing page to implement one of these bandwidth-priced streams, they have no Alchemy request/response docs or examples, so please either add the corresponding API reference pages/overview entries or limit this pricing section to methods that are actually documented.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex's observation is factually correct — the five newly-priced Sui gRPC streaming methods (
SubscribeTransactions,SubscribeEvents,ListCheckpoints,ListTransactions,ListEvents) do not have per-method API reference pages under the Sui gRPC section today.SubscribeCheckpointsis the only Sui streaming method with any docs presence, and it was in thecu:auto product="sui-grpc"table strictly because Daikon'stopconfig.ymlgrouped it there for per-method CU tracking (removed in this PR since it's actually bandwidth-priced).Not applying the fix here because:
cu:auto product="sui-grpc"scope; adding real reference pages requires coordinated changes inOMGWINNING/chain-config(topconfig.yml+chainconfig/) before the docs side can stabilize. That's a separate cross-repo workstream, not a small docs edit.geyser.Geyser/Subscribestream without linking to a dedicated per-method API reference page — the pricing disclosure and the API reference surface have historically been decoupled here.The underlying gap (bandwidth-priced streaming methods lack dedicated API reference pages) is worth tracking, but as a follow-up ticket rather than blocking this pricing clarification. Leaving the thread open so a human reviewer can decide whether to spin one off.