Conversation
This will help with compatibility with Microsoft Intune
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for producing and shipping a Windows MSI installer (WiX) alongside the existing Windows Squirrel installer, to enable distribution via Intune Company Portal (Issue #413). It also refactors the release workflow into reusable composite actions so Windows/macOS build + artifact upload steps are shared across prod/beta releases.
Changes:
- Add Electron Forge WiX maker configuration and helper version handling to produce an
.msiartifact. - Introduce a Windows signing hook to serialize signtool invocations and support the new Windows packaging flow.
- Refactor GitHub Actions release workflow into composite actions (deploy-macos, deploy-windows, upload-release-assets) and update docs/config accordingly.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/windows-sign-serial-hook.cjs | Adds a serializing signing hook for Windows to avoid concurrent signtool/KMS provider conflicts. |
| forge.config.ts | Adds MakerWix, WiX-compliant version derivation, and Squirrel-specific signing hook configuration. |
| package.json | Adds Windows-specific make scripts and the WiX maker dependency; updates version/metadata. |
| pnpm-lock.yaml | Locks new dependencies introduced for WiX/MSI packaging. |
| pnpm-workspace.yaml | Allows building the exe-icon-extractor dependency needed by MSI tooling. |
| README.md | Documents Windows packaging options and WiX prerequisites; cleans up a dependency note. |
| .github/workflows/release.yml | Splits prod/beta release jobs and delegates build/upload logic to composite actions. |
| .github/actions/deploy-windows/action.yml | New composite action to build/sign Windows artifacts and upload them. |
| .github/actions/deploy-macos/action.yml | New composite action to build/sign macOS artifacts and upload them. |
| .github/actions/upload-release-assets/action.yml | New composite action to download artifacts and attach them to the GitHub release. |
| .github/dependabot.yml | Attempts to expand GitHub Actions updates to composite action directories. |
| .github/ISSUE_TEMPLATE/bug-report.yml | Fixes “macOS” casing in the OS dropdown. |
| .vscode/settings.json | Adds project-specific spellings related to the new workflow/signing terminology. |
| CHANGELOG.md | Records the release-candidate history related to MSI/WiX experimentation and fixes. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
acneville
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps with #413 by adding an MSI installer to the release artifacts. This took a lot of experimenting with the InTune team but it finally seems to be working.