fix: cleanup uses fresh context after volume create failure#541
Open
Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Open
fix: cleanup uses fresh context after volume create failure#541Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Conversation
if the failure was a ctx deadline or cancel, cleanup used the same ctx and failed for the same reason, leaking the volume. give it a fresh 30s timeout instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If CreateVolume fails because ctx is done (deadline or cancel), the
best-effort cleanup call reused the same ctx and failed for the same
reason right away, leaking the already-created external volume.
Cleanup now gets its own 30s timeout, detached from the original ctx.