Use the full snapshot scope by default for the counter demo#520
Open
Michael Shen (mjlshen) wants to merge 1 commit into
Open
Use the full snapshot scope by default for the counter demo#520Michael Shen (mjlshen) wants to merge 1 commit into
Michael Shen (mjlshen) wants to merge 1 commit into
Conversation
The Data snapshot scope is meant to restore state from DurableDir volumes and does not persist the process memory. For this demo, it makes more sense to default to the Full snapshot scope.
Michael Shen (mjlshen)
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Data snapshot scope is meant to restore state from DurableDir volumes and does not persist the process memory. For this demo, it makes more sense to default to the Full snapshot scope so that users can play around with incrementing a counter, pausing/resuming with the previous value still intact, and continue incrementing the counter.
Fixes #519