Correction du téléchargement de facture (#2270)#2271
Open
upskaling wants to merge 2 commits into
Open
Conversation
stakovicz
approved these changes
Jun 2, 2026
stakovicz
reviewed
Jun 2, 2026
| <td>{{ invoice.forum_titre }}</td> | ||
| <td class="right aligned"> | ||
| <a href="/pages/administration/index.php?page=forum_facturation&action=telecharger_facture&ref={{ invoice.reference }}" | ||
| <a href="{{ url('admin_event_factures_download_facture', {'ref': invoice.reference}) }}" |
Contributor
There was a problem hiding this comment.
Tu penses que tu peux ajouter (ou compléter) un test fonctionnel pour valider le lien de téléchargement ?
Mopolo
reviewed
Jun 2, 2026
| Then the "h2.ui.header" element should contain "Factures Forum" | ||
| And the ".content table" element should contain "REF-TEST-001" | ||
| And the ".content table" element should contain "Helios Aerospace" | ||
| When I follow the PDF download link for invoice "REF-TEST-001" in the events invoices section |
Contributor
There was a problem hiding this comment.
Plutôt qu'une nouvelle phrase très spécifique à ce test, il vaudrait mieux utiliser l'existant pour lire un pdf.
Tu as des exemples dans ces tests : https://github.com/afup/web/blob/master/tests/behat/features/Admin/Events/FacturesEvennement.feature
upskaling
force-pushed
the
fix/2270-telechargement-facture
branch
from
c061629 to
1890b53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2270