feat: Update AttachmentList to support Illustrations for preview and update invalid styling for preview only - #10452
Open
LFDanLu wants to merge 8 commits into
Open
feat: Update AttachmentList to support Illustrations for preview and update invalid styling for preview only#10452LFDanLu wants to merge 8 commits into
LFDanLu wants to merge 8 commits into
Conversation
…llustration and text
…n, get rid of reliance on horizontal card
|
Build successful! 🎉 |
snowystinger
left a comment
Member
There was a problem hiding this comment.
fully delete the HorizontalCard file?
couple quick things
|
Build successful! 🎉 |
Agent Skills ChangesModified (2)
InstallReact Spectrum S2: React Aria: |
snowystinger
approved these changes
Aug 12, 2026
snowystinger
left a comment
Member
There was a problem hiding this comment.
Looks pretty good. I assume the invalid to the right of the text is by design? It'd be nice if it replaced the thumb/icon just like the square ones, it'd take up less space and wouldn't shift things if it became invalid then valid or vice versa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From testing + local testing. Updates AttachmentList to use Illustrations instead of Icons for previews, updates invalid styling for preview only attachments (opacity + adds invalid icon to center of the attachment), and removes reliance on HorizontalCard since that isn't meant have the same styling (S2 vs AI styling)
✅ Pull Request Checklist:
📝 Test Instructions:
Test the "Mixed attachments" story across invalid/in progress upload/etc. Also test isInvalid + only image preview via the "AI attachments" story.
🧢 Your Project:
RSP