fix: commit ColorField value on Enter, matching NumberField behavior (Fixes #10445) - #10446
Open
waterWang wants to merge 1 commit into
Open
fix: commit ColorField value on Enter, matching NumberField behavior (Fixes #10445)#10446waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
snowystinger
left a comment
Member
There was a problem hiding this comment.
Thanks for the speedy PR
Please add tests, there are probably some in RAC NumberField that you can base them on.
| Enter: () => { | ||
| flushSync(() => { | ||
| commit(); | ||
| }); |
Member
There was a problem hiding this comment.
I suspect we'll need the commitValidation as well so that it gets marked invalid before an implicit form submission
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pressing Enter in a
ColorFieldnow commits the typed value, matching the behavior ofNumberField. Previously, typing a hex value and pressing Enter would silently retain the input display but not commit it to the color state — the value was only flushed on blur. If the user then closed aColorPickerpopover with Escape, the typed value was silently discarded and the previous color restored.Implementation
Mirrors the
useNumberFieldEnter handling pattern (useKeyboardwithflushSync(() => commit())):flushSyncimport fromreact-domuseKeyboardimport from../interactions/useKeyboardonKeyDownandonKeyUpto props destructuringuseKeyboardhook with an Enter shortcut that callsflushSync(() => commit())keyboardPropsfirst in themergePropschain so shortcuts run before other handlersRelated
Test plan