broadcast: propagate subscriber exceptions instead of swallowing - #22
Merged
Conversation
A raising subscriber on the default BroadcastDispatcher was caught and logged, so it could never fail the operation it observed. Let it propagate; earlier subscribers in the fire still ran, later ones don't. Class-level (@observe/Reporter) subscribers and ConcurrentDispatcher still isolate their own failures, and WorkQueue keeps its ack/nack/DLQ path untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BroadcastDispatcher.dispatch wrapped every subscriber in try/except and only logged, so a raising subscriber (e.g. an assertion hook) could never fail the operation — the fire returned and the caller continued.
Now a subscriber exception propagates: earlier subscribers still run, the first exception aborts the rest of that fire and surfaces to the caller. Verified no consumer relied on the swallow (WorkQueue competing-consumer, RPCServer, and the @observe/Reporter path each have their own independent error handling and are untouched). Full suite green.