feat(dispatcher): LeastLoadedDispatcher.route() returns the result - #21
Merged
Conversation
Factors the atomic select-and-reserve into _select(), shared by the existing fire-and-forget dispatch() and a new route() that invokes the chosen subscriber and returns its result (propagating errors). Lets a scheduler reuse the load-aware routing instead of reimplementing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factors the atomic select-and-reserve out of
dispatch()into a shared_select(), and addsroute(subscribers, *args, **kwargs) -> Any— the result-returning counterpart of the fire-and-forgetdispatch(). A scheduler that needs the value back (e.g. torchestrator's pools) can now reuse the load-aware routing + atomic reservation instead of reimplementing it.dispatch()behaviour is unchanged (saturated propagates, handler errors swallowed/logged);route()propagates handler errors and releases the reservation either way. Tests for route's result, error-propagation, and release. 32 green, lint/mypy clean.