feat(node): atomic try_acquire/release for race-free scheduling - #19
Merged
Conversation
Adds Node.try_acquire() (reserve a slot iff spare capacity) and release(), so a scheduler can make select-and-reserve atomic and never double-book a capacity-1 node under concurrent dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Node.try_acquire()/Node.release()so a scheduler can make the select-and-reserve step atomic. Without it, a least-loaded picker readsload(), picks, then runs — two concurrent picks can both grab a capacity-1 node (→ GPU double-booking / OOM in the torchestrator pools).try_acquirereserves under the node lock and returns whether a slot was free.Tests: capacity respect, no-negative release, and a 20-thread contention test asserting exactly one acquire wins per slot. Lint/format/mypy clean.