refactor(c2): delete 5 dead-twin orphan modules; reclassify ai/preview as 4.5-seeds#51
Merged
Merged
Conversation
…w as 4.5-seeds Delete the 5 dead-twin orphan dirs (health, migrate, preflight, storage, worker — 9 files, 492 sh-lines), all live-path clean (per-module grep over actools.sh/installer/cli/profiles/cron = 0 hits). Remove their 3 dangling shellcheck lines from lint.yml (preflight, storage, worker); the 15 remaining all resolve and pass. Update runtime-authority-map.md inventory to 13 dirs (6 live + 7 4.5-seed), reclassify ai/preview dead-twin -> 4.5-seed (kept for C3 quarantine), update the worker Current-state row, and align the audit wording to 'from actools.sh'. Guard comment aligned (logic + EXPECTED_LIVE_MODULES byte-identical). Behavior-changing (ships fewer files): branch e2e green required before merge. Baseline: ce35813 (#50).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase C2 (Track C cleanup) · baseline ce35813 (#50).
Removes 5 dead-twin orphan modules — health, migrate, preflight, storage, worker
(9 files, ~492 lines) — that shipped to prod but were never on the live path:
per-module grep over actools.sh / installer/ / cli/ / profiles/ / cron/ = 0 hits,
and every live-called helper survives in a kept module (modules/stack/images.sh,
modules/db/core.sh). ai and preview are kept and reclassified as 4.5-seeds for
quarantine in C3.
Also: drops the 3 now-dangling lint.yml shellcheck lines (preflight/storage/worker);
updates the runtime-authority-map "Standalone modules" inventory to 13 dirs
(6 live + 7 4.5-seed); ledger Entry 022 (Pending) + Entry 021 ratified. The
orphan-inventory guard is comment-only — EXPECTED_LIVE_MODULES and derive_live_modules
byte-identical — and stays green (guards 23/23 + non-vacuous, golden 9/9). No code,
no golden fixtures, no historical records touched.
Reviewed in separate Opus sessions: REVIEW = APPROVE, DOC-CHECK = PASS.
Gate: behavior-changing (ships fewer files) — do not merge until CI is green AND a
branch e2e run reaches "MariaDB ready."