Skip to content

Remove redundant "so this fails the rule".#2428

Open
daniel-montalvo wants to merge 8 commits into
developfrom
daniel-montalvo-patch-2
Open

Remove redundant "so this fails the rule".#2428
daniel-montalvo wants to merge 8 commits into
developfrom
daniel-montalvo-patch-2

Conversation

@daniel-montalvo

Copy link
Copy Markdown
Collaborator

Remove redundant sentence, we are already in the failed examples section.
Need for Call for Review:
This can be merged with 1 approval << choose reason: editorial changes to website/test code, adding new contributor, other (explain).


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".
  • If your PR is for a new rule with an Accessibility Support note, or for updating the Accessibility Support note of an existing section, make sure to open a corresponding Accessibility Support issue.

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@netlify

netlify Bot commented Jul 13, 2026

Copy link
Copy Markdown

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 6ed6081
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/6a61f70694a45a000862ab21
😎 Deploy Preview https://deploy-preview-2428--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@daniel-montalvo
daniel-montalvo marked this pull request as draft July 13, 2026 11:47
WilcoFiers
WilcoFiers previously approved these changes Jul 20, 2026
@daniel-montalvo
daniel-montalvo marked this pull request as ready for review July 22, 2026 11:29
@daniel-montalvo
daniel-montalvo dismissed stale reviews from dan-tripp-siteimprove and WilcoFiers July 22, 2026 11:31

Found a couple more instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants