Skip to content

[Accton] Check TX_DISABLE support before access in onlp_sfpi_control_… #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric271110 wants to merge 5 commits into
base: support_linux_6.1
Choose a base branch
from
Open

[Accton] Check TX_DISABLE support before access in onlp_sfpi_control_… #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8947d9
[Accton] Check TX_DISABLE support before access in onlp_sfpi_control_…
eric271110 Jun 12, 2026
95acf33
[Accton] remove redundant CMIS bank setting in control_get/set
eric271110 Jun 15, 2026
2dc2a4d
[Accton]Add SFP functionality (LP mode, reset, TX disable)
eric271110 Jun 15, 2026
1756289
[Accton] Move QSFP-DD bank-select to before page 10h switch
eric271110 Jun 23, 2026
16df657
[Accton] sfpi.c: replace AIM_LOG_ERROR with syslog and remove unneces…
eric271110 Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 77 additions & 48 deletions ...atforms/accton/x86-64/as7535-28xb/onlp/builds/x86_64_accton_as7535_28xb/module/src/sfpi.c
View file
Open in desktop

Large diffs are not rendered by default.

108 changes: 70 additions & 38 deletions ...forms/accton/x86-64/as7926-40xfb/onlp/builds/x86_64_accton_as7926_40xfb/module/src/sfpi.c
View file
Open in desktop

Large diffs are not rendered by default.

109 changes: 70 additions & 39 deletions ...atforms/accton/x86-64/as7946-30xb/onlp/builds/x86_64_accton_as7946_30xb/module/src/sfpi.c
View file
Open in desktop

Large diffs are not rendered by default.

109 changes: 70 additions & 39 deletions ...forms/accton/x86-64/as7946-74xkb/onlp/builds/x86_64_accton_as7946_74xkb/module/src/sfpi.c
View file
Open in desktop

Large diffs are not rendered by default.

112 changes: 72 additions & 40 deletions ...platforms/accton/x86-64/as9716_32d/onlp/builds/x86_64_accton_as9716_32d/module/src/sfpi.c
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 2 additions & 10 deletions ...platforms/accton/x86-64/as9726-32d/onlp/builds/x86_64_accton_as9726_32d/module/src/sfpi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,6 @@ int onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
if (status_byte & QSFP_DD_FLAT_MEM) {
return ONLP_STATUS_E_UNSUPPORTED;
}
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_BANK_SELECT, 0)) < 0) {
syslog(LOG_ERR, "Failed to set Bank 0, unable to write tx_disable status to port(%d)", port);
return ONLP_STATUS_E_INTERNAL;
}
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADVERTISING)) < 0) {
syslog(LOG_ERR, "Failed to switch to Advertising Page on port(%d)", port);
goto restore;
Expand All @@ -398,7 +394,7 @@ int onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
}
if (support_ctrls & QSFP_DD_P01H_TX_DISABLE_SUPPORT) {
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_BANK_SELECT, 0)) < 0) {
syslog(LOG_ERR, "Failed to set Bank 0 on port(%d)", port);
syslog(LOG_ERR, "Failed to set Bank 0, unable to write tx_disable status to port(%d)", port);
goto restore;
}
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL)) < 0) {
Expand Down Expand Up @@ -554,10 +550,6 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
if (status_byte & QSFP_DD_FLAT_MEM) {
return ONLP_STATUS_E_UNSUPPORTED;
}
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_BANK_SELECT, 0)) < 0) {
syslog(LOG_ERR, "Failed to set Bank 0, unable to read tx_disable status from port(%d)", port);
return ONLP_STATUS_E_INTERNAL;
}
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADVERTISING)) < 0) {
syslog(LOG_ERR, "Failed to switch to Advertising Page on port(%d)", port);
goto restore;
Expand All @@ -569,7 +561,7 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
}
if (support_ctrls & QSFP_DD_P01H_TX_DISABLE_SUPPORT) {
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_BANK_SELECT, 0)) < 0) {
syslog(LOG_ERR, "Failed to set Bank 0 on port(%d)", port);
syslog(LOG_ERR, "Failed to set Bank 0, unable to read tx_disable status from port(%d)", port);
goto restore;
}
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL)) < 0) {
Expand Down
106 changes: 69 additions & 37 deletions ...platforms/accton/x86-64/as9736-64d/onlp/builds/x86_64_accton_as9736_64d/module/src/sfpi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include "x86_64_accton_as9736_64d_int.h"
#include "x86_64_accton_as9736_64d_log.h"
#include "platform_lib.h"
#include <syslog.h>

#define SFP_PORT_MIN 64
#define SFP_PORT_MAX 65
Expand Down Expand Up @@ -94,6 +95,8 @@
#define QSFP_DD_PAGE_ADMIN_INFO 0x0
#define QSFP_DD_PAGE_ADVERTISING 0x1
#define QSFP_DD_PAGE_LANE_CTRL 0x10
#define QSFP_DD_LOWER_OFFSET_STATUS 0x02
#define QSFP_DD_FLAT_MEM 0x80 /* byte 0x02 bit 7 */
#define QSFP_DD_P01H_TX_DISABLE_SUPPORT 0x2


Expand Down Expand Up @@ -155,7 +158,7 @@ int onlp_sfpi_is_present(int port)
VALIDATE_PORT(port);

if (onlp_file_read_int(&present, MODULE_PRESENT_FORMAT, (port+1)) < 0) {
AIM_LOG_ERROR("Unable to read present status from port(%d)\r\n"
syslog(LOG_ERR, "Unable to read present status from port(%d)"
, port);
return ONLP_STATUS_E_INTERNAL;
}
Expand Down Expand Up @@ -189,7 +192,7 @@ int onlp_sfpi_rx_los_bitmap_get(onlp_sfp_bitmap_t* dst)

fp = fopen(MODULE_RXLOS_ALL_ATTR, "r");
if (fp == NULL) {
AIM_LOG_ERROR("Unable to open the module_rx_los_all device file.");
syslog(LOG_ERR, "Unable to open the module_rx_los_all device file.");
return ONLP_STATUS_E_INTERNAL;
}

Expand All @@ -199,7 +202,7 @@ int onlp_sfpi_rx_los_bitmap_get(onlp_sfp_bitmap_t* dst)
fclose(fp);
if (count != 9) {
/* Likely a read timeout. */
AIM_LOG_ERROR("Unable to read all fields from the module_rx_los_all device file.");
syslog(LOG_ERR, "Unable to read all fields from the module_rx_los_all device file.");
return ONLP_STATUS_E_INTERNAL;
}

Expand Down Expand Up @@ -232,7 +235,7 @@ int onlp_sfpi_rx_los_bitmap_get(onlp_sfp_bitmap_t* dst)
} else {
if (onlp_file_read_int(&rx_loss, MODULE_RXLOS_FORMAT,
(i+1)) < 0) {
AIM_LOG_ERROR("Unable to read rxloss status from port(%d)\r\n"
syslog(LOG_ERR, "Unable to read rxloss status from port(%d)"
, i+1);
return ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -259,20 +262,20 @@ int onlp_sfpi_eeprom_read(int port, uint8_t data[256])
if (port <= 31) {
if (onlp_file_read(data, 256, &size, UDB_PORT_EEPROM_FORMAT,
port) != ONLP_STATUS_OK) {
AIM_LOG_ERROR("Unable to read eeprom from port(%d)\r\n", port);
syslog(LOG_ERR, "Unable to read eeprom from port(%d)", port);
return ONLP_STATUS_E_INTERNAL;
}
} else {
if (onlp_file_read(data, 256, &size, LDB_PORT_EEPROM_FORMAT,
port-32) != ONLP_STATUS_OK) {
AIM_LOG_ERROR("Unable to read eeprom from port(%d)\r\n", port);
syslog(LOG_ERR, "Unable to read eeprom from port(%d)", port);
return ONLP_STATUS_E_INTERNAL;
}
}


if (size != 256) {
AIM_LOG_ERROR("Unable to read eeprom from port(%d), size is different!\r\n",
syslog(LOG_ERR, "Unable to read eeprom from port(%d), size is different!",
port);
return ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -289,22 +292,22 @@ int onlp_sfpi_dom_read(int port, uint8_t data[256])
sprintf(file, PORT_EEPROM_FORMAT, onlp_sfpi_map_bus_index(port));
fp = fopen(file, "r");
if (fp == NULL) {
AIM_LOG_ERROR("Unable to open the eeprom device file of port(%d)",
syslog(LOG_ERR, "Unable to open the eeprom device file of port(%d)",
port);
return ONLP_STATUS_E_INTERNAL;
}

if (fseek(fp, 256, SEEK_CUR) != 0) {
fclose(fp);
AIM_LOG_ERROR("Unable to set the file position indicator of port(%d)",
syslog(LOG_ERR, "Unable to set the file position indicator of port(%d)",
port);
return ONLP_STATUS_E_INTERNAL;
}

int ret = fread(data, 1, 256, fp);
fclose(fp);
if (ret != 256) {
AIM_LOG_ERROR("Unable to read the module_eeprom device file of port(%d)",
syslog(LOG_ERR, "Unable to read the module_eeprom device file of port(%d)",
port);
return ONLP_STATUS_E_INTERNAL;
}
Expand Down Expand Up @@ -419,6 +422,7 @@ int onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
int rv = ONLP_STATUS_E_INTERNAL;
int present = 0;
int identifier = 0;
int status_byte = 0;
int eeprom_control;

VALIDATE_PORT(port);
Expand All @@ -431,7 +435,7 @@ int onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
if (port >= SFP_PORT_MIN && port <= SFP_PORT_MAX) { //SFP
if (onlp_file_write_int(value, MODULE_TXDISABLE_FORMAT,
(port + 1)) < 0) {
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d)\r\n",
syslog(LOG_ERR, "Unable to write tx_disable status to port(%d)",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -442,48 +446,55 @@ int onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
else { //QSFP
identifier = onlp_sfpi_eeprom_readb(port, QSFP_EEPROM_OFFSET_IDENTIFIER);
if (identifier < 0) {
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d): read identifier from eeprom fail\r\n",
syslog(LOG_ERR, "Unable to write tx_disable status to port(%d): read identifier from eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (identifier == QSFP_DD_IDENTIFIER) { /* QSFP DD */
if (onlp_sfpi_eeprom_writeb(port, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADVERTISING) < 0) {
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d): write page to eeprom fail\r\n",
/* Flat-memory CMIS modules do not implement page 01h/10h */
if ((status_byte = onlp_sfpi_eeprom_readb(port, QSFP_DD_LOWER_OFFSET_STATUS)) < 0) {
syslog(LOG_ERR, "Failed to read Status byte, unable to write tx_disable status to port(%d)", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (status_byte & QSFP_DD_FLAT_MEM) {
rv = ONLP_STATUS_E_UNSUPPORTED;
}
else if (onlp_sfpi_eeprom_writeb(port, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADVERTISING) < 0) {
syslog(LOG_ERR, "Unable to write tx_disable status to port(%d): write page to eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
eeprom_control = onlp_sfpi_eeprom_readb(port, QSFP_DD_EEPROM_P01H_OFFSET_CONTROL_1);
if (eeprom_control < 0) {
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d): read control from eeprom fail\r\n",
syslog(LOG_ERR, "Unable to write tx_disable status to port(%d): read control from eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (eeprom_control & QSFP_DD_P01H_TX_DISABLE_SUPPORT) {
if (onlp_sfpi_eeprom_writeb(port, QSFP_DD_EEPROM_OFFSET_BANK_SELECT, 0) < 0) {
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d): write bank to eeprom fail\r\n",
syslog(LOG_ERR, "Unable to write tx_disable status to port(%d): write bank to eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (onlp_sfpi_eeprom_writeb(port, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL) < 0) {
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d): write page to eeprom fail\r\n",
syslog(LOG_ERR, "Unable to write tx_disable status to port(%d): write page to eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (onlp_sfpi_eeprom_writeb(port, QSFP_DD_EEPROM_P10H_OFFSET_OUTPUT_DISABLE_TX, value) < 0) {
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d): write TX disable to eeprom fail\r\n",
syslog(LOG_ERR, "Unable to write tx_disable status to port(%d): write TX disable to eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
rv = ONLP_STATUS_OK;
}
} else {
AIM_LOG_ERROR("Setting tx disable to port(%d) is not supported\r\n", port);
rv = ONLP_STATUS_E_UNSUPPORTED;
}
if (onlp_sfpi_eeprom_writeb(port, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADMIN_INFO) < 0) {
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d): write page to eeprom fail\r\n",
syslog(LOG_ERR, "Unable to write tx_disable status to port(%d): write page to eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -493,7 +504,7 @@ int onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
value = value & 0xf;

if (onlp_sfpi_eeprom_writeb(port, QSFP_EEPROM_OFFSET_TXDIS, value) < 0) {
AIM_LOG_ERROR("Unable to write tx_disable status to port(%d): write TX disable to eeprom fail\r\n",
syslog(LOG_ERR, "Unable to write tx_disable status to port(%d): write TX disable to eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -513,7 +524,7 @@ int onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)

if (onlp_file_write_int(value, MODULE_RESET_FORMAT,
(port + 1)) < 0) {
AIM_LOG_ERROR("Unable to write reset status to port(%d)\r\n",
syslog(LOG_ERR, "Unable to write reset status to port(%d)",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -527,7 +538,7 @@ int onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)

if (onlp_file_write_int(value, MODULE_LPMODE_FORMAT,
(port + 1)) < 0) {
AIM_LOG_ERROR("Unable to write LP mode status to port(%d)\r\n",
syslog(LOG_ERR, "Unable to write LP mode status to port(%d)",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -549,6 +560,8 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
int rv = ONLP_STATUS_E_INTERNAL;
int present = 0;
int identifier = 0;
int status_byte = 0;
int support_ctrls = 0;
int tx_dis = 0;

VALIDATE_PORT(port);
Expand All @@ -558,7 +571,7 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
VALIDATE_SFP(port);
if (onlp_file_read_int(value, MODULE_RXLOS_FORMAT,
(port+1)) < 0) {
AIM_LOG_ERROR("Unable to read rx_loss status from port(%d)\r\n",
syslog(LOG_ERR, "Unable to read rx_loss status from port(%d)",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -571,7 +584,7 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
VALIDATE_SFP(port);
if (onlp_file_read_int(value, MODULE_TXFAULT_FORMAT,
(port+1)) < 0) {
AIM_LOG_ERROR("Unable to read tx_fault status from port(%d)\r\n",
syslog(LOG_ERR, "Unable to read tx_fault status from port(%d)",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -587,7 +600,7 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
if (port >= SFP_PORT_MIN && port <= SFP_PORT_MAX) {
if (onlp_file_read_int(value, MODULE_TXDISABLE_FORMAT,
(port+1)) < 0) {
AIM_LOG_ERROR("Unable to read tx_disabled status from port(%d)\r\n",
syslog(LOG_ERR, "Unable to read tx_disabled status from port(%d)",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -598,43 +611,62 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
else {
identifier = onlp_sfpi_eeprom_readb(port, QSFP_EEPROM_OFFSET_IDENTIFIER);
if (identifier < 0) {
AIM_LOG_ERROR("Unable to read tx_disabled status from port(%d): read identifier from eeprom fail\r\n",
syslog(LOG_ERR, "Unable to read tx_disabled status from port(%d): read identifier from eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (identifier == QSFP_DD_IDENTIFIER) { /* QSFP DD */
if (onlp_sfpi_eeprom_writeb(port, QSFP_DD_EEPROM_OFFSET_BANK_SELECT, 0) < 0) {
AIM_LOG_ERROR("Unable to read tx_disable status from port(%d): write bank to eeprom fail\r\n",
/* Flat-memory CMIS modules do not implement page 01h/10h */
if ((status_byte = onlp_sfpi_eeprom_readb(port, QSFP_DD_LOWER_OFFSET_STATUS)) < 0) {
syslog(LOG_ERR, "Failed to read Status byte, unable to read tx_disable status from port(%d)", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (status_byte & QSFP_DD_FLAT_MEM) {
rv = ONLP_STATUS_E_UNSUPPORTED;
}
else if (onlp_sfpi_eeprom_writeb(port, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADVERTISING) < 0) {
syslog(LOG_ERR, "Failed to switch to Advertising Page on port(%d)", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if ((support_ctrls = onlp_sfpi_eeprom_readb(port, QSFP_DD_EEPROM_P01H_OFFSET_CONTROL_1)) < 0) {
syslog(LOG_ERR, "Failed to read Support Control on port(%d)", port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (!(support_ctrls & QSFP_DD_P01H_TX_DISABLE_SUPPORT)) {
rv = ONLP_STATUS_E_UNSUPPORTED;
}
else if (onlp_sfpi_eeprom_writeb(port, QSFP_DD_EEPROM_OFFSET_BANK_SELECT, 0) < 0) {
syslog(LOG_ERR, "Unable to read tx_disable status from port(%d): write bank to eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
else if (onlp_sfpi_eeprom_writeb(port, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL) < 0) {
AIM_LOG_ERROR("Unable to read tx_disable status from port(%d): write page to eeprom fail\r\n",
port);
syslog(LOG_ERR, "Failed to switch to Lane Control Page (Page 0x%02x) on port(%d)",
QSFP_DD_PAGE_LANE_CTRL, port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
tx_dis = onlp_sfpi_eeprom_readb(port, QSFP_DD_EEPROM_P10H_OFFSET_OUTPUT_DISABLE_TX);
if (tx_dis < 0) {
AIM_LOG_ERROR("Unable to read tx_disable status from port(%d): read TX disable from eeprom fail\r\n",
syslog(LOG_ERR, "Unable to read tx_disable status from port(%d): read TX disable from eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
else {
*value = tx_dis;
*value = (tx_dis & 0xff);
rv = ONLP_STATUS_OK;
}
}
if (onlp_sfpi_eeprom_writeb(port, QSFP_DD_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADMIN_INFO) < 0) {
AIM_LOG_ERROR("Unable to read tx_disable status from port(%d): write page to eeprom fail\r\n",
syslog(LOG_ERR, "Unable to read tx_disable status from port(%d): write page to eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
}
else { /* QSFP 28 or QSFP+ */
tx_dis = onlp_sfpi_eeprom_readb(port, QSFP_EEPROM_OFFSET_TXDIS);
if (tx_dis < 0) {
AIM_LOG_ERROR("Unable to read tx_disable status from port(%d): read TX disable from eeprom fail\r\n",
syslog(LOG_ERR, "Unable to read tx_disable status from port(%d): read TX disable from eeprom fail",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -655,7 +687,7 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)

if (onlp_file_read_int(value, MODULE_RESET_FORMAT,
(port + 1)) < 0) {
AIM_LOG_ERROR("Unable to read reset status from port(%d)\r\n",
syslog(LOG_ERR, "Unable to read reset status from port(%d)",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand All @@ -669,7 +701,7 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)

if (onlp_file_read_int(value, MODULE_LPMODE_FORMAT,
(port + 1)) < 0) {
AIM_LOG_ERROR("Unable to read LP mode status from port(%d)\r\n",
syslog(LOG_ERR, "Unable to read LP mode status from port(%d)",
port);
rv = ONLP_STATUS_E_INTERNAL;
}
Expand Down
Loading