feat(verification): add PlantUML and Vocabulary support for Docker-based verification - #271
Merged
Merged
Conversation
…sed verification - Introduced PlantUML and Vocabulary as new targets in the Docker verification setup. - Updated package.json and Dockerfiles to include necessary configurations for PlantUML and Vocabulary validation. - Added new validation tests for PlantUML syntax and Vocabulary structure to ensure proper generation and verification. - Enhanced the verification manifest to include PlantUML and Vocabulary as targets. This commit expands the verification capabilities to include PlantUML and Vocabulary, ensuring a consistent environment for testing and validation. Signed-off-by: Apoorv <130035517+APOORV7G@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the Docker-based codegen verification harness with two new schema targets: PlantUML and Vocabulary. Each target gets a Docker image, an entrypoint that generates from the corpus and runs an external validator, a local Mocha verification test, registration in
verification/docker/targets.jsonandscripts/verification/docker-run.js, averify:docker:<target>npm script, and a matrix entry in.github/workflows/verify-codegen.yml.Changes
plantumlandvocabularyinverification/docker/targets.json.scripts/verification/docker-run.jsTARGETSto include both.verify:docker:plantuml,verify:docker:vocabulary.verify-codegenGitHub Actions matrix.test/verification/cases.jsto mentionplantumlandvocabulary.verification/templates/plantuml-*.jar(downloaded on first local test run).PlantUML (
plantuml)verification/docker/plantuml/Dockerfileandentrypoint.sh.fontconfig/ DejaVu fonts (PlantUML loads fontmanager even for-syntax), and downloadsplantuml-1.2024.7.jarat build time..pumlvia CLI targetPlantUML, then syntax-checks each file withjava -jar plantuml.jar -syntax.test/verification/plantuml.validate.test.js: generates withPlantUMLVisitor, validates with the official PlantUML jar. Downloads the jar intoverification/templates/on first run when missing (override withPLANTUML_JAR). Skips when Java is not installed.Vocabulary (
vocabulary)verification/docker/vocabulary/Dockerfile,entrypoint.sh, andvalidate.js.@accordproject/concerto-vocabularydependency; no extra packages required.Vocabulary, then validates each.vocfile withVocabularyManager.addVocabularyviavalidate.js.test/verification/vocabulary.validate.test.js: generates withVocabularyVisitorand reuses the samevalidate.jshelper for structural checks (locale, namespace, declarations).Flags
VocabularyManager), not a full round-trip against a ModelManager locale set.Author Checklist
--signoffoption of git commit.mainfromfork:branchname