test: add integration test for holdings total_value multi snapshot up…#592
Open
toniasteve15-ui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes #584
Add integration test for holdings endpoint returning correct total_value after multiple price snapshot updates
Closes #584
Description
This PR introduces a new integration test for the
/api/v1/wallets/:address/holdingsendpoint to ensure thetotal_valuecalculation accurately tracks dynamic price updates.Summary
The holdings endpoint computes the total value of held keys dynamically from the latest price snapshot. This integration test confirms the value is recalculated correctly when a creator's price snapshot is updated multiple times, guaranteeing that the most recent snapshot value is always utilized.
Scope Covered
5keys held).100,250,300)./holdingsAPI endpoint after each snapshot update.total_valueconsistently aligns with the most recent snapshot (500,1250,1500).Acceptance Criteria Met
total_valueuses the latest snapshot after each updateTesting Instructions
pnpm test src/modules/wallets/__tests__/wallet-holdings-multiple-snapshots.integration.test.ts#closes